Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Message-ID: <584DB1E6.5020203@gmail.com>
Date: Sun, 11 Dec 2016 15:07:02 -0500
From: Josh Elser <josh.elser@gmail.com>
User-Agent: Postbox 3.0.11 (Macintosh/20140602)
MIME-Version: 1.0
To: dev@hbase.apache.org
CC: "dev@phoenix.apache.org" <dev@phoenix.apache.org>
Subject: Re: Coprocessor metrics
References: <CAMUu0w-WsqtFFaNR-1rkmMiADEAUtWW2=zkFYdKHFm76S9taRg@mail.gmail.com> <CANZa=GvFj1EPnYUKJ4a-CeJRt9y41HfxQ9zQ5GwDfOw_zpuJDQ@mail.gmail.com> <5829DF26.7080808@apache.org> <CAMUu0w_kQXtFp8ZUAo2nGZ0jtWxoTHcSSiih8_V1R85Y+AH1kQ@mail.gmail.com> <CAMUu0w9+sCAPDZafiMgNDqadH7GZhukgpPmMBmAnoxeSsP-3kA@mail.gmail.com>
In-Reply-To: <CAMUu0w9+sCAPDZafiMgNDqadH7GZhukgpPmMBmAnoxeSsP-3kA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Sun, 11 Dec 2016 20:07:21 -0000


Enis Söztutar wrote:
> Bumping this up in case people are interested.
>
> Also this is not coprocessor-specific, because I think we can incrementally
> start using the new hbase-metrics module, and get rid of our complicated
> metrics2 based patterns for core metrics as well. We should of course start
> enforcing that all new metrics be using the new approach (if there is
> consensus).  See HBASE-14282.
>
> I've uploaded a v1 patch for
> https://issues.apache.org/jira/browse/HBASE-9774. It is a mix between
> approach (2) and (3). The API looks like the DW metrics (with still some
> differences), but the implementations mostly come from HBase (except for
> Meter).
>
> @Phoenix devs, feel free to provide feedback if you intend to export
> metrics from Phoenix by piggy backing on the RS metrics.

Would definitely like to play around with this from the Phoenix side, 
but I probably won't get any time for a week or two :). I'll try to 
remember to send a note when I find the time.

 From the HBase side, the code looks good to me, but I don't want to you 
to wait for me to merge it in :)

> Enis