hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guanghao Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-17088) Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
Date Mon, 14 Nov 2016 12:20:58 GMT
Guanghao Zhang created HBASE-17088:
--------------------------------------

             Summary: Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
                 Key: HBASE-17088
                 URL: https://issues.apache.org/jira/browse/HBASE-17088
             Project: HBase
          Issue Type: Improvement
          Components: rpc
    Affects Versions: 2.0.0
            Reporter: Guanghao Zhang


1. The RWQueueRpcExecutor has eight constructor method and the longest one has ten parameters.
But It is only used in SimpleRpcScheduler and easy to confused when read the code.
2. There are duplicate method implement in RWQueueRpcExecutor and BalancedQueueRpcExecutor.
They can be implemented in their parent class RpcExecutor.
3. SimpleRpcScheduler read many configs to new RpcExecutor. But the CALL_QUEUE_SCAN_SHARE_CONF_KEY
is only needed by RWQueueRpcExecutor. And CALL_QUEUE_CODEL_TARGET_DELAY, CALL_QUEUE_CODEL_INTERVAL
and CALL_QUEUE_CODEL_LIFO_THRESHOLD are only needed by AdaptiveLifoCoDelCallQueue.

So I thought we can refactor it. Suggestions are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message