hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: [DISCUSS] EOL 1.1 Release Branch
Date Tue, 08 Nov 2016 16:44:49 GMT
Thanks Nick!

On Tue, Nov 8, 2016 at 7:51 AM, Nick Dimiduk <ndimiduk@apache.org> wrote:

> You're right Enis, sounds like we'll continue on with 1.1. No issues on my
> side, I'm happy to continue producing these releases as I'm able.
>
> Thanks everyone for the discussion.
>
> On Monday, November 7, 2016, Enis Söztutar <enis@apache.org> wrote:
>
> > Going back to the original discussion, the conclusion is to continue with
> > 1.1 line for now, and re-evaluate in a couple of months it seems.
> >
> > Nick do you want to keep driving the next 1.1 releases, or you want to
> let
> > Andrew do that? I can help as well if needed.
> >
> > Enis
> >
> > On Mon, Nov 7, 2016 at 12:17 PM, Andrew Purtell <
> andrew.purtell@gmail.com
> > <javascript:;>>
> > wrote:
> >
> > > I have a patch for this and will be trying it out.
> > >
> > > On Nov 7, 2016, at 12:00 PM, Gary Helmling <ghelmling@gmail.com
> > <javascript:;>> wrote:
> > >
> > > >>
> > > >> I'm not deeply familiar with the AssignmentManager. I see when we
> > > process
> > > >> split rollbacks in onRegionSplit() we only call regionOffline() on
> > > >> daughters if they are known to exist. However when processing merge
> > > >> rollbacks in the else case of onRegionMerge() we unconditionally
> call
> > > >> regionOffline() on the parent-being-merged. Shouldn't that likewise
> be
> > > >> conditional on regionStates holding a state for the
> > parent-being-merged?
> > > >> Pardon if I've missed something.
> > > >>
> > > >>
> > > > I'm really not familiar with the merge code, but this seems plausible
> > to
> > > > me.  I see that onRegionSplit() has an early out at the top of the
> > > method,
> > > > but that will fail to evaluate if rs_a and rs_b are open and rs_p is
> > > null.
> > > > So if it's called with a code of MERGE_REVERTED, I think we could
> wind
> > up
> > > > creating an offline meta entry for rs_p with no regioninfo, similar
> to
> > > > HBASE-16093.  And that entry could wind up hiding the (still online)
> > > > daughter regions.
> > >
> >
>



-- 
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message