hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ChiaPing Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-16729) Define the behavior of (default) empty FilterList
Date Thu, 29 Sep 2016 09:31:20 GMT
ChiaPing Tsai created HBASE-16729:
-------------------------------------

             Summary: Define the behavior of (default) empty FilterList
                 Key: HBASE-16729
                 URL: https://issues.apache.org/jira/browse/HBASE-16729
             Project: HBase
          Issue Type: Wish
            Reporter: ChiaPing Tsai
            Priority: Trivial


Current empty FilterList filters all data, because the FilterList#isFamilyEssential always
returns false which causes the null cell retrieved by RegionScannerImpl.storeHeap.

It seems to me that empty FilterList should do nothing, because the following code is common.
{noformat}
private static Filter makeFilter() {
  FilterList filterList = new FilterList ();
  for (some conditions) {
    // add some filters. Or nothing to add.
  }
  return filterList;
}
{noformat}

If we keep the current logic which filters all data, we should add enough comments to explain
it. Or add the FilterList#size() or FilterList#empty() for preventing filtering all data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message