hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-15693) Reconsider the ImportOrder rule of checkstyle
Date Fri, 22 Apr 2016 11:52:12 GMT
Duo Zhang created HBASE-15693:

             Summary: Reconsider the ImportOrder rule of checkstyle
                 Key: HBASE-15693
                 URL: https://issues.apache.org/jira/browse/HBASE-15693
             Project: HBase
          Issue Type: Bug
          Components: build
            Reporter: Duo Zhang
            Assignee: Duo Zhang

I have been confused many times with the wrong import order checkstyle warnings in the pre
commit result. And I haven't found any developer guide which tells me what is the right order
so this time I decided to read the rule by myself.

In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only work
with option 'top' or 'bottom'(which means place static imports on top or bottom) and use the
default option which is 'under'.

I prefer placing static import on top, so I suggest here we set option to 'top'.

This message was sent by Atlassian JIRA

View raw message