hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-15296) Break out writer and reader from StoreFile
Date Sat, 20 Feb 2016 02:29:18 GMT
Appy created HBASE-15296:
----------------------------

             Summary: Break out writer and reader from StoreFile
                 Key: HBASE-15296
                 URL: https://issues.apache.org/jira/browse/HBASE-15296
             Project: HBase
          Issue Type: Improvement
          Components: regionserver
            Reporter: Appy
            Assignee: Appy


StoreFile.java is trending to become a monolithic class, it's ~1800 lines. Would it make sense
to break out reader and writer (~500 lines each) into separate files.

We are doing so many different things in a single class: comparators, reader, writer, other
stuff; and it hurts readability a lot, to the point that just reading through a piece of code
require scrolling up and down to see which level (reader/writer/base class level) it belongs
to. These small-small things really don't help while trying to understanding the code. There
are good reasons we don't do these often (affects existing patches, needs to be done for all
branches, etc). But this and a few other classes can really use a single iteration of refactoring
to make things a lot better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message