hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhe Zhang <zhezh...@cloudera.com>
Subject Re: Potential Gerrit support in review/commit flow
Date Fri, 06 Nov 2015 07:09:31 GMT
> One question: is it possible to enfore fast-forward only commits when
> pushing upstream via the web UI? A history full of merge
> commits is not very palatable from our community perspective.

Thanks for the question Nick. Yes Gerrit can be configured to allow only
fast-forward commits (that's actually the default "submit type" setting).
When your change is outdated it will be highlighted and a "rebase" button
will be provided.

Zhe Zhang

On Thu, Nov 5, 2015 at 4:33 PM, Zhe Zhang <zhz@apache.org> wrote:

> Hi HBase contributors,
> The Hadoop community is considering adding Gerrit as a review / commit
> tool. Since this will require support from the Apache Infra team, it makes
> more sense if multiple projects can benefit from the effort.
> The main benefit of Gerrit over ReviewBoard is better integration with git
> and Jenkins. A Gerrit review request is created through a simple "git push"
> instead of manually creating and uploading a diff file. Conflicts detection
> and rebase can be done on the review UI as well. When the programmed commit
> criteria are met (e.g. a code review +1 and a Jenkins verification),
> committing can also be done with a single button click, or even
> automatically.
> This also just augments instead of replacing the current review / commit
> flow. Every task will still start as a JIRA. Review comments can be made on
> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> also be directly committed through git command line (Gerrit will recognize
> a direct commit and close the review request as long as a simple git hook
> is installed:
> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
> I wonder if the HBase community would be interested in moving on this
> direction as well. Any feedback is much appreciated.
> Thanks,
> Zhe Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message