hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: MOB in branch-1? (Re: [RESULT][VOTE] Merge branch hbase-11339 HBase MOB to trunk)
Date Tue, 27 Oct 2015 23:52:23 GMT
IMO, MOB is still not settled in Master. It has a bunch of flakey tests
that are getting fixed by Jingcheng or I've disabled them till someone has
time to look at them. There is also a load of duplicated code that is being
cleaned up (Matteo).

Its not ready to go back to branch-1 IMO.

Are there users who'd like it backported?
St.Ack


On Mon, Oct 26, 2015 at 10:55 AM, Stephen Jiang <syuanjiangdev@gmail.com>
wrote:

> Hello, guys, the MOB is in master branch.  I saw bug fixes happening in
> master branch.
>
> I just wonder whether there is a plan to put MOB in branch-1.  I am afraid
> if we don't do it now, it would be harder in the future to back port if we
> decide to do it in a late time.
>
> Thanks
> Stephen
>
> On Thu, Jul 23, 2015 at 1:15 PM, Andrew Purtell <apurtell@apache.org>
> wrote:
>
> > Thanks Jon.
> >
> > When I'm back in the office I'll check out master and have a look into
> any
> > locally repeatable test failures. Anyway in my opinion at this point it
> > would make the most sense for us to keep the MOB changes in on master and
> > deal with any fallout in follow on issues. I think all who voted +1 for
> > this change were aware that large changes like this can have a
> temporarily
> > destabilizing effect. As long as the MOB devs are around to help clean
> up,
> > we should be good!
> >
> >
> > On Wed, Jul 22, 2015 at 8:09 PM, Jonathan Hsieh <jon@cloudera.com>
> wrote:
> >
> > > I had two clean full builds/unit test on my internal setup and the
> latest
> > > build went back to ~4325 total tests and failures on Procedure relate
> > tests
> > > cases.
> > >
> > > I don't think mob is responsible for these failures.
> > >
> > > Jon.
> > >
> > > On Wed, Jul 22, 2015 at 4:32 PM, Jonathan Hsieh <jon@cloudera.com>
> > wrote:
> > >
> > > > Although the the precommit buiid passed, and the compilation and mob
> > > > testing I ran after before the merge was commited passed, It looks
> like
> > > > the first full build after the merge [1] failed.  It looked like
> > > > something hung along the way, and that most of the previous builds
> had
> > > > failed for various reasons. :(
> > > >
> > > > I kicked it off again have it do another try.  If it is mob related
> > we'll
> > > > take hunt it down and take care of it.
> > > >
> > > > Jon.
> > > >
> > > > [1] https://builds.apache.org/job/HBase-TRUNK/6672/
> > > >
> > > > On Wed, Jul 22, 2015 at 1:16 PM, Jonathan Hsieh <jon@cloudera.com>
> > > wrote:
> > > >
> > > >> I've merged the code in to master.  Thanks for all the hard work
> > > >> Jingcheng and thanks to all who have been involved with reviews,
> > > >> discussion, and voting!
> > > >>
> > > >> Jon
> > > >>
> > > >> On Wed, Jul 22, 2015 at 12:45 AM, Jingcheng Du <
> > jingcheng.du@intel.com>
> > > >> wrote:
> > > >>
> > > >>> Hi all,
> > > >>>
> > > >>> The vote passes with 8 +1s and no -1. Thanks all for guiding,
> helping
> > > and
> > > >>> voting!
> > > >>> We will work on the merge activities and will let guys know about
> the
> > > >>> detailed plan for merge time.
> > > >>> And thanks Jon for helping merge this branch to trunk!
> > > >>>
> > > >>> Regards,
> > > >>> Jingcheng
> > > >>>
> > > >>>
> > > >>>
> > > >>> --
> > > >>> View this message in context:
> > > >>>
> > >
> >
> http://apache-hbase.679495.n3.nabble.com/RESULT-VOTE-Merge-branch-hbase-11339-HBase-MOB-to-trunk-tp4073446.html
> > > >>> Sent from the HBase Developer mailing list archive at Nabble.com.
> > > >>>
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> // Jonathan Hsieh (shay)
> > > >> // HBase Tech Lead, Software Engineer, Cloudera
> > > >> // jon@cloudera.com // @jmhsieh
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > // Jonathan Hsieh (shay)
> > > > // HBase Tech Lead, Software Engineer, Cloudera
> > > > // jon@cloudera.com // @jmhsieh
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > // Jonathan Hsieh (shay)
> > > // HBase Tech Lead, Software Engineer, Cloudera
> > > // jon@cloudera.com // @jmhsieh
> > >
> >
> >
> >
> > --
> > Best regards,
> >
> >    - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message