Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
MIME-Version: 1.0
Sender: saint.ack@gmail.com
In-Reply-To: 
 <CAPQQKxf2c6XRXnWWDOgb2VkJvWrHVyCxDTBThtXEqJV9SLkj1Q@mail.gmail.com>
References: 
 <CAPQQKxf2c6XRXnWWDOgb2VkJvWrHVyCxDTBThtXEqJV9SLkj1Q@mail.gmail.com>
Date: Wed, 16 Sep 2015 10:06:25 -0700
Message-ID: 
 <CADcMMgGcJ-4PuL+=Df-xCje=Wnn91K6N1W-0RjPVGRZ8AjjhWA@mail.gmail.com>
Subject: Re: formatter.rb not respect width > 2 columns
From: Stack <stack@duboce.net>
To: Stephen Jiang <syuanjiangdev@gmail.com>
Cc: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: multipart/alternative; boundary=047d7bdc19189fb32d051fe0517e

--047d7bdc19189fb32d051fe0517e
Content-Type: text/plain; charset=UTF-8

On Wed, Sep 16, 2015 at 9:50 AM, Stephen Jiang <syuanjiangdev@gmail.com>
wrote:

> It is interesting that in formatter.rb, if more than 2 columns, it would
> not respect the width passed in.  Why is that?  I am thinking about change
> it, but I'd like to know the reason behind it.
>
> Or is it ok to keep this way, even the output is not ideal?
>
>         if args.length == 1
>           ...
>         elsif args.length == 2
>          ...
>           end
>         else
>           # Print a space to set off multi-column rows
>           print ' '
>           first = true
>           for e in args
>             @out.print " " unless first
>             first = false
>             @out.print e
>           end
>          ...
>         end
>


Probably because two columns was all we ever needed: row key and then the
value and if only one value, then show it as one column. Have at it Stephen.

Ideally though formatter.rb would go away -- it is an awful hack -- and
we'd have a 'real' console results formatter that did a better job. When I
looked back then, all were incompatibly licensed. That may have changed
(this looks ok on cursory glance:
https://github.com/thedathoudarya/WAGU-data-in-table-view... or could we
hack in sqlline -- https://github.com/julianhyde/sqlline -- or some such..).

St.Ack

--047d7bdc19189fb32d051fe0517e--