Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0567418949 for ; Sun, 5 Jul 2015 17:53:06 +0000 (UTC) Received: (qmail 95199 invoked by uid 500); 5 Jul 2015 17:53:05 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 95107 invoked by uid 500); 5 Jul 2015 17:53:05 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 94766 invoked by uid 99); 5 Jul 2015 17:53:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Jul 2015 17:53:05 +0000 Date: Sun, 5 Jul 2015 17:53:05 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (HBASE-13998) Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John reopened HBASE-13998: ------------------------------------ Reopening to commit an addendum to fix an induced javadoc warn. > Remove CellComparator#compareRows(byte[] left, int loffset, int llength, byte[] right, int roffset, int rlength) > ---------------------------------------------------------------------------------------------------------------- > > Key: HBASE-13998 > URL: https://issues.apache.org/jira/browse/HBASE-13998 > Project: HBase > Issue Type: Sub-task > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-13998.patch, HBASE-13998_addendum.patch > > > A public API in CellComparator which takes old style byte[], offset, length alone is not correct. CellComparator supposed to compare cell(s). At least one side param has to be a cell.. This is the agreement we discussed in HBASE-10800. Still we could not remove the above one method because it was getting used from multiple places. Now most of the usage is removed. This jira aims at removing it fully and replace the usage with other APIs. > Note: The CellComparator is added in 2.0 only so removing the public API is not creating any BC issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)