Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7EBC118176 for ; Thu, 9 Jul 2015 01:06:39 +0000 (UTC) Received: (qmail 24985 invoked by uid 500); 9 Jul 2015 01:06:38 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 24899 invoked by uid 500); 9 Jul 2015 01:06:38 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 24887 invoked by uid 99); 9 Jul 2015 01:06:38 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 01:06:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0994ED3240 for ; Thu, 9 Jul 2015 01:06:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.901 X-Spam-Level: ** X-Spam-Status: No, score=2.901 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cbV3A5Zskabq for ; Thu, 9 Jul 2015 01:06:29 +0000 (UTC) Received: from mail-yk0-f178.google.com (mail-yk0-f178.google.com [209.85.160.178]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 81EE520F46 for ; Thu, 9 Jul 2015 01:06:29 +0000 (UTC) Received: by ykey15 with SMTP id y15so27223008yke.3 for ; Wed, 08 Jul 2015 18:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=z2jbHdGu7YzW5eVszVboXdGkItIFgTP4Quq1YMZx4fc=; b=TmTsOuMAn7BIK454rg41bkx9GXmXiMuc2iP1IAugQGi88QmKXw0Me51hANkv3hg/Bp 910yK9pF5mpOWycshflrE6h3fP+JixhjyxBZgYYol90vA3JZbMTYL1RLWkPL/zvekTeF JHOStZl6i4FZ/jj30+o+08s5bhB2pM6X8rW/zItPSRyaiZOcw4Q6CvrboN9D/wPjA7g9 HdhdEJ5soUqnt8DEJESoKUnewsw5Qfi6AR7jiEer8CEGa63TiIl6V7mxilV28zFSfFs9 +NLfeJHWLCC+X+aIyeFyXRN66rhQcW9HRznjv/JvGkwn2gCq/EAt8LZRD9kk8bWAHH7j XoUQ== MIME-Version: 1.0 X-Received: by 10.170.160.4 with SMTP id b4mr14493710ykd.26.1436403936589; Wed, 08 Jul 2015 18:05:36 -0700 (PDT) Received: by 10.37.208.142 with HTTP; Wed, 8 Jul 2015 18:05:36 -0700 (PDT) In-Reply-To: References: Date: Wed, 8 Jul 2015 18:05:36 -0700 Message-ID: Subject: Re: [DISCUSS] Distributed Log Replay in branch-1 From: Ted Yu To: "dev@hbase.apache.org" Content-Type: multipart/alternative; boundary=001a113a7b9064fe73051a66daf1 --001a113a7b9064fe73051a66daf1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable bq. set up at least Jenkins based integration tests that exercise the code paths +1 On Wed, Jul 8, 2015 at 5:45 PM, Andrew Purtell wrote: > I think we should leave it enabled in master and set up at least Jenkins > based integration tests that exercise the code paths. Otherwise, we might > be better off removing the DLR code rather than have it rot in place. > > On Wed, Jul 8, 2015 at 11:48 AM, Enis S=C3=B6ztutar = wrote: > > > On Wed, Jul 8, 2015 at 10:23 AM, Stack wrote: > > > > > On Wed, Jul 8, 2015 at 7:53 AM, Sean Busbey > wrote: > > > > > > > Hi Folks! > > > > > > > > For the 1.2 release, I think the consensus is to disable Distribute= d > > Log > > > > Replay by default due to lack of sufficient testing. At least, that= 's > > the > > > > only feedback I've heard so far. :) > > > > > > > > > > > > > > Anyone object to that? > > > > > > > > > > > I've been trying it over the last few days. It is easy enough to lose > > > data: HBASE-14028. It is a bit tough tracing how the loss is happeni= ng > > > given more moving parts and that it seems few have treaded this route > > > previously; breadcrumbs are sparse (fixing). > > > > > > I'll keep at this until DLR in 1.2 is for sure a lost cause. > > > > > > On DLR: > > > > > > + DLR is a little more involved than DLS -- which is already tough > enough > > > to follow. It might be best to just punt and come back here after > assign > > > has been redone (and simplified) on top of pv2; hbase-2.0.0? > > > > > > > Agreed. DLR is a very good idea, but unfortunately has not stabilized > > enough. The recovery semantics, zk interactions, assignment, etc make = it > > very complex to understand and operate. I would vote for not doing any > more > > work on this side unless we have solved the assignment process. The oth= er > > problem is that we cannot have only DLR since if the table is offline D= LS > > is needed, which forces us to maintain and test two different subsystem= s. > > In the long term, we should be shooting for a simplified solution. > > > > Let's disable in master as well. Once / if we have better testing we ca= n > > always re-enable it. > > > > Enis > > > > > > > + It can actually make for a worse MTTR as it does not do re-lookups > > during > > > replay of a WAL if the target server crashes during DLR; the whole WA= L > > > replay must timeout before we'll go re-find the new location (30 > seconds > > at > > > least). > > > > > > St.Ack > > > > > > > > > Presuming no one does,what do folks think about just disabling it by > > > > default in the current branch-1? > > > > > > > > > > > > > > That isn't to say it couldn't switch to on-by-default at a latter 1= .y > > > > release. It's just that we had to turn it off right before the 1.1 > > > releases > > > > as well, and I'd prefer we avoid these last minute changes in favor > of > > > > waiting until someone has the time to prioritize thorough testing. > > > > > > > > > > > > > > > > > > > > > -- > > > > Sean > > > > > > > > > > > > > -- > Best regards, > > - Andy > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) > --001a113a7b9064fe73051a66daf1--