hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Busbey <bus...@cloudera.com>
Subject Re: Ok to remove and change return types on methods in a public/unstable testing utility class in hbase-2.0.0?
Date Wed, 17 Jun 2015 16:56:01 GMT
We have a ticket for that move[1], though it is poorly named at this point.
IIRC several of the classes already have interface annotations.


[1]: HBASE-13126

On Wed, Jun 17, 2015 at 11:36 AM, Andrew Purtell <apurtell@apache.org>
wrote:

> In my opinion the first step toward making anything in src/test/...
> supportable is moving it to src/main/ and adding suitable interface
> annotations.
>
>
> On Wed, Jun 17, 2015 at 9:10 AM, Stack <stack@duboce.net> wrote:
>
> > I am looking at changes to a HBaseTestingUtility base class over in the
> > nice cleanup issue HBASE-13893.  HTU is a pretty popular testing tool.
> >
> > I'm thinking that is is not OK removing methods and changing param and
> > return types even though its across a major version (and even though it
> > marked unstable) because we should spare the user pain where we can.
> >
> > On other hand, we are purging HTable references, old crud, the
> preservation
> > of which is useless and will make for a mountain of work.
> >
> > Opinions?
> >
> > St.Ack
> >
>
>
>
> --
> Best regards,
>
>    - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>



-- 
Sean

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message