Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C19A010647 for ; Thu, 8 Jan 2015 20:26:34 +0000 (UTC) Received: (qmail 85909 invoked by uid 500); 8 Jan 2015 20:26:35 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 85751 invoked by uid 500); 8 Jan 2015 20:26:35 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 85470 invoked by uid 99); 8 Jan 2015 20:26:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2015 20:26:35 +0000 Date: Thu, 8 Jan 2015 20:26:34 +0000 (UTC) From: "stack (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-6664) Filter compound comparators nor comparator subclasses are compared properly by test code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-6664. -------------------------- Resolution: Won't Fix Closing. See Gregory's justification > Filter compound comparators nor comparator subclasses are compared properly by test code > ---------------------------------------------------------------------------------------- > > Key: HBASE-6664 > URL: https://issues.apache.org/jira/browse/HBASE-6664 > Project: HBase > Issue Type: Bug > Components: test > Reporter: stack > Labels: delete > > Gregory over in https://reviews.apache.org/r/6670/ explains the issue. See the comment here at https://reviews.apache.org/r/6670/diff/1/?file=142078#file142078line88 Its about when tests call areSerializedFieldsEqual to figure if objects are equal. When its comparators, and the comparator has been subclassed or is made of multiple sub comparators, then we'll not compare right. -- This message was sent by Atlassian JIRA (v6.3.4#6332)