hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cosmin Lehene (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-7859) errors from creating ZK offline node are not handled
Date Thu, 08 Jan 2015 09:59:35 GMT

     [ https://issues.apache.org/jira/browse/HBASE-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cosmin Lehene resolved HBASE-7859.
----------------------------------
    Resolution: Duplicate

[~sershe] it looks like this is fixed in a duplicate issue. Please update if necessary. Closing
as duplicate

> errors from creating ZK offline node are not handled
> ----------------------------------------------------
>
>                 Key: HBASE-7859
>                 URL: https://issues.apache.org/jira/browse/HBASE-7859
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Priority: Minor
>
> Quote from HBASE-7799
> {quote}
> What i observed was
> {code}
> try {
>       ZKAssign.asyncCreateNodeOffline(watcher, state.getRegion(),
>         destination, cb, state);
>     } catch (KeeperException e) {
>       if (e instanceof NodeExistsException) {
>         LOG.warn("Node for " + state.getRegion() + " already exists");
>       } else {
>         server.abort("Unexpected ZK exception creating/setting node OFFLINE", e);
>       }
>       return false;
>     }
> return true;
> {code}
> The asyncCreateNodeOffline just always returns true because it does not wait for the
callback to take action. Also the callback does not throw NodeExistsException.
> {quote}
> In short the catch block is a dead code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message