hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cosmin Lehene (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-7780) HStore has a bunch of strange StoreFile reader null checks
Date Thu, 08 Jan 2015 09:51:34 GMT

     [ https://issues.apache.org/jira/browse/HBASE-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Cosmin Lehene resolved HBASE-7780.
----------------------------------
    Resolution: Incomplete

[~sershe] closing this for now. I'm sure this still applies, but it seems a desire for refactoring
rather than a bug (which may be the case for a large part of the codebase) and may be worth
reopening when a patch is available 

> HStore has a bunch of strange StoreFile reader null checks
> ----------------------------------------------------------
>
>                 Key: HBASE-7780
>                 URL: https://issues.apache.org/jira/browse/HBASE-7780
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Priority: Minor
>
> In many places, especially around compactions, we check whether the file reader is null,
and do stuff like skip the file or do quick exit if it is. In some places we don't do it.
> Why would file reader be null? Probably these checks can be removed or made stricter
(assert?).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message