Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6818A10DCB for ; Tue, 30 Dec 2014 04:36:14 +0000 (UTC) Received: (qmail 98882 invoked by uid 500); 30 Dec 2014 04:36:13 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 98732 invoked by uid 500); 30 Dec 2014 04:36:13 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 98467 invoked by uid 99); 30 Dec 2014 04:36:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Dec 2014 04:36:13 +0000 Date: Tue, 30 Dec 2014 04:36:13 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-5323) Need to handle assertion error while splitting log through ServerShutDownHandler by shutting down the master MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan resolved HBASE-5323. ------------------------------------------- Resolution: Won't Fix 0.90.x version is no more active. Resolving as 'Won't fix'. > Need to handle assertion error while splitting log through ServerShutDownHandler by shutting down the master > ------------------------------------------------------------------------------------------------------------ > > Key: HBASE-5323 > URL: https://issues.apache.org/jira/browse/HBASE-5323 > Project: HBase > Issue Type: Bug > Affects Versions: 0.90.5 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Attachments: HBASE-5323.patch, HBASE-5323.patch > > > We know that while parsing the HLog we expect the proper length from HDFS. > In WALReaderFSDataInputStream > {code} > assert(realLength >= this.length); > {code} > We are trying to come out if the above condition is not satisfied. But if SSH.splitLog() gets this problem then it lands in the run method of EventHandler. This kills the SSH thread and so further assignment does not happen. If ROOT and META are to be assigned they cannot be. > I think in this condition we abort the master by catching such exceptions. > Please do suggest. -- This message was sent by Atlassian JIRA (v6.3.4#6332)