Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of andrew.purtell@gmail.com
 designates 209.85.214.174 as permitted sender)
From: Andrew Purtell <andrew.purtell@gmail.com>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-D5333721-25AE-4E1A-9DC4-6F1C14790C9A
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Subject: Considering a RpcSchedulerFactory change in 0.98 for HBASE-12028
Message-Id: <ACAA9754-2691-4B5D-87CE-D6188F0952E5@gmail.com>
Date: Tue, 30 Dec 2014 14:49:15 -0800
Cc: HBase Dev List <dev@hbase.apache.org>
To: "dev@phoenix.apache.org" <dev@phoenix.apache.org>

--Apple-Mail-D5333721-25AE-4E1A-9DC4-6F1C14790C9A
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable

Hi Phoenix,

Please see https://issues.apache.org/jira/browse/HBASE-12028

The proposed change if committed into 0.98 branch would introduce a new 'cre=
ate' method into the RpcSchedulerFactory interface that receives an Abortabl=
e as an additional parameter. Thus, the factory can pass this on to schedule=
rs and workers and if something terrible happens in or to a RPC handler they=
 can trigger a server abort. Due to a design oversight we don't otherwise ha=
ve this capability. In my opinion it is important to fix this oversight. (Ph=
oenix can also potentially make use of the Abortable for fatal issues involv=
ing indexes.) Otherwise RPC handlers can silently terminate upon receiving a=
n unhandled throwable, potentially leaving behind bad state, certainly impac=
ting performance and availability. However because RpcSchedulerFactory is an=
 interface any implementor will not compile after this change, until updated=
.

HBase could include this change in the next 0.98 release or not. Please advi=
se.=20


--Apple-Mail-D5333721-25AE-4E1A-9DC4-6F1C14790C9A--