hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enis Söztutar <enis....@gmail.com>
Subject Re: Considering a RpcSchedulerFactory change in 0.98 for HBASE-12028
Date Tue, 30 Dec 2014 23:14:12 GMT
Thanks Andrew,

Once HBASE-12028 is committed it should be easy enough to make the changes
in Phoenix to be able to compile with HBase versions pre or post
HBASE-12028. But we need a PHOENIX issue for that.

We should also make Abortable a LimitedPrivate it seems.

Enis

On Tue, Dec 30, 2014 at 2:49 PM, Andrew Purtell <andrew.purtell@gmail.com>
wrote:

> Hi Phoenix,
>
> Please see https://issues.apache.org/jira/browse/HBASE-12028
>
> The proposed change if committed into 0.98 branch would introduce a new
> 'create' method into the RpcSchedulerFactory interface that receives an
> Abortable as an additional parameter. Thus, the factory can pass this on to
> schedulers and workers and if something terrible happens in or to a RPC
> handler they can trigger a server abort. Due to a design oversight we don't
> otherwise have this capability. In my opinion it is important to fix this
> oversight. (Phoenix can also potentially make use of the Abortable for
> fatal issues involving indexes.) Otherwise RPC handlers can silently
> terminate upon receiving an unhandled throwable, potentially leaving behind
> bad state, certainly impacting performance and availability. However
> because RpcSchedulerFactory is an interface any implementor will not
> compile after this change, until updated.
>
> HBase could include this change in the next 0.98 release or not. Please
> advise.
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message