hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-12566) HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
Date Mon, 24 Nov 2014 22:43:14 GMT
Andrew Purtell created HBASE-12566:

             Summary: HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
                 Key: HBASE-12566
                 URL: https://issues.apache.org/jira/browse/HBASE-12566
             Project: HBase
          Issue Type: Bug
            Reporter: Andrew Purtell
             Fix For: 2.0.0, 0.98.9, 0.99.2

I've discovered after HBASE-12550 that Phoenix has an IndexSplitTransaction class that was
broken by a change to a package scoped method:
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
index 39a9fdc..3377e6b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
@@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{
    * Create a daughter region from given a temp directory with the region data.
    * @param hri Spec. for daughter region to open.
+   * @param expectedReferenceFileCount
    * @throws IOException
-  HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException {
+  HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount)
throws IOException {
     // Move the files from the temporary .splits to the final /table/region directory
-    fs.commitDaughterRegion(hri);
+    fs.commitDaughterRegion(hri, expectedReferenceFileCount);

We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, PHOENIX).

This message was sent by Atlassian JIRA

View raw message