hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-12517) Several HConstant members are assignable
Date Tue, 18 Nov 2014 21:10:34 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-12517.
---------------------------
       Resolution: Fixed
    Fix Version/s: 0.99.2
                   0.98.9
                   2.0.0
     Hadoop Flags: Reviewed

Pushed to 0.98+ Thanks for the patch [~busbey]

> Several HConstant members are assignable
> ----------------------------------------
>
>                 Key: HBASE-12517
>                 URL: https://issues.apache.org/jira/browse/HBASE-12517
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>              Labels: beginner, checkstyle
>             Fix For: 2.0.0, 0.98.9, 0.99.2
>
>         Attachments: HBASE-12517.1.patch.txt
>
>
> Several of the members in HConstants are not marked final.
> Generate up-to-date list with command:
> 0.98+
> {code}
> for line in "`grep -e '^ *public' hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
| grep -v final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> 0.94:
> {code}
> for line in "`grep -e '^ *public' src/main/java/org/apache/hadoop/hbase/HConstants.java
| grep -v final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> These mutable versions have been in many releases. We correctly don't assign to them
in our codebase, but there's no way to know if anyone does downstream.
> HConstants is IA.Public and IS.Stable, but I'm fairly certain this behavior was unintentional
and there isn't a non-broken use for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message