Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of yuzhihong@gmail.com designates
 209.85.160.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAAG4q_UvggXtqotYmjnv1492-ySJrUM3y2-2580s5uS1ure7FA@mail.gmail.com>
References: 
 <CAAG4q_VfXXHM0+4mbdiK2bN-XMcHa_Ja9cEyHocqpwD0ReL-fQ@mail.gmail.com>
	<CALte62zMoZGU5RdXcQCejuNnvnXnu8jYYjhcF53iED0gSWKgQQ@mail.gmail.com>
	<CAAG4q_V5PeCpnzf8PMK+uOm4qmCL64zpSYQjk2AywGNQ2v3C0A@mail.gmail.com>
	<CALte62ycnkFX-T7nWaVBc2imFanfUoaOGX6HYyc9xuRcxBMO1Q@mail.gmail.com>
	<CAAG4q_X8-HwmuRfvVesao8jRa=cpVij2esa3uJ6TaTWU+8=+qQ@mail.gmail.com>
	<CALte62yr8RzR3oe9avAmqmGQoTO=-e_g=T2N93WTwW1kFSQJFw@mail.gmail.com>
	<CAEf3A-ywLCBnW2BmuwjpJGEZgHDwWXCfHcvRMywhrhRdaSc+7A@mail.gmail.com>
	<CAAG4q_UvggXtqotYmjnv1492-ySJrUM3y2-2580s5uS1ure7FA@mail.gmail.com>
Date: Mon, 13 Oct 2014 07:21:19 -0700
Message-ID: 
 <CALte62z7UMUXw4GseEtip7hJZy94URLsAzY9246_qwC1Y=X+ZA@mail.gmail.com>
Subject: Re: A Chome extension for rendering patch on JIRA
From: Ted Yu <yuzhihong@gmail.com>
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: multipart/alternative; boundary=089e01160180cc0b6505054e9cbb

--089e01160180cc0b6505054e9cbb
Content-Type: text/plain; charset=UTF-8

bq. you have to scroll horizontally?

That's what I observe - the left pane has unused margin close to the center
of the view.

Cheers

On Mon, Oct 13, 2014 at 6:36 AM, David DENG <daviddengcn@gmail.com> wrote:

> @tobe I fixed the width assuming the code is generally of maximum 100 chars
> per line. Or are you saying that it is too wide so that you have to scroll
> horizontally?
>
> David
>
> On Mon, Oct 13, 2014 at 12:31 AM, tobe <tobeg3oogle@gmail.com> wrote:
>
> > The extension is great and it saves me day. But it's not full-screen by
> > default when I open a patch. Maybe something related to the resolution.
> > Anyway, thanks @david for your work!
> >
> > On Sun, Oct 12, 2014 at 12:43 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> >
> > > Thanks for the fast turnaround.
> > >
> > > I just installed the extension. Viewing patch becomes much pleasant
> now.
> > >
> > > Cheers
> > >
> > > On Sat, Oct 11, 2014 at 9:37 PM, David DENG <daviddengcn@gmail.com>
> > wrote:
> > >
> > > > Published a new version of the exteions:
> > > >
> > > > 1. An icon is shown right to the address bar. When viewing patch in
> an
> > > > arbitrary url, click on the icon, it'll be rendered. This support
> cause
> > > the
> > > > extension needs a re-enabling when upgraded. (Sorry for the
> > re-enalbing)
> > > >
> > > > 2. Add an option page to set url patterns which are auto rendered.
> > > Default
> > > > values are Apache jira patches (added [.]txt pattern)
> > > >
> > > > David
> > > >
> > > > On Fri, Oct 10, 2014 at 6:22 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> > > >
> > > > > Yes.
> > > > >
> > > > > See https://issues.apache.org/jira/browse/HBASE-12164
> > > > >
> > > > > On Fri, Oct 10, 2014 at 5:58 PM, David DENG <daviddengcn@gmail.com
> >
> > > > wrote:
> > > > >
> > > > > > @Ted, people also submit patch with .txt extension?
> > > > > >
> > > > > > David
> > > > > >
> > > > > > On Fri, Oct 10, 2014 at 5:35 PM, Ted Yu <yuzhihong@gmail.com>
> > wrote:
> > > > > >
> > > > > > > Interesting.
> > > > > > >
> > > > > > > Can you add the following to the recognized patterns ?
> > > > > > >
> > > > > > > https://issues.apache.org/jira/secure/attachment/*/*.
> > > > > > > <https://issues.apache.org/jira/secure/attachment/*/*.patch
> >txt
> > > > > > >
> > > > > > > On Fri, Oct 10, 2014 at 4:57 PM, David DENG <
> > daviddengcn@gmail.com
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg
> > > > > > > >
> > > > > > > > Go to one of the JIRA patch, the raw text will be rendered
> as a
> > > > > > > Phabricator
> > > > > > > > like page (Like http://review.facebook.net/ ).
> > > > > > > > Recognized URL pattern:
> > > > > > > > https://issues.apache.org/jira/secure/attachment/*/*.patch
> > > > > > > >
> > > > > > > > Source code and bug report:
> > > > https://github.com/daviddengcn/patch-ext
> > > > > > > >
> > > > > > > > Have a try and enjoy!
> > > > > > > >
> > > > > > > > David
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

--089e01160180cc0b6505054e9cbb--