Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 209.85.213.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAAG4q_W1-pAoFH_cX1pYmdyiAb4tyL-bQ3i6hY9-TseJvkYJ=A@mail.gmail.com>
References: 
 <CAAG4q_VfXXHM0+4mbdiK2bN-XMcHa_Ja9cEyHocqpwD0ReL-fQ@mail.gmail.com>
	<CALte62zMoZGU5RdXcQCejuNnvnXnu8jYYjhcF53iED0gSWKgQQ@mail.gmail.com>
	<CAAG4q_V5PeCpnzf8PMK+uOm4qmCL64zpSYQjk2AywGNQ2v3C0A@mail.gmail.com>
	<CALte62ycnkFX-T7nWaVBc2imFanfUoaOGX6HYyc9xuRcxBMO1Q@mail.gmail.com>
	<CAAG4q_X8-HwmuRfvVesao8jRa=cpVij2esa3uJ6TaTWU+8=+qQ@mail.gmail.com>
	<CALte62zVjQR7_hNwxxytHp6s0UrZOrnYNz43Zk2P92Z_zaV0hQ@mail.gmail.com>
	<CAEf3A-zQz0oxSxYkrZU8N17zYJXJo_2n5uKmyjUYsb8eWtdC1A@mail.gmail.com>
	<CAAG4q_VY3bTBe3t_K_yQAqbG_QdBXn4=vX=hSoiTWxeSLTcGTg@mail.gmail.com>
	<CAAG4q_WQzSbWawYz5TxM8iFmAK1S-pYyc5nYm+swcORtbbFa+A@mail.gmail.com>
	<CALte62w766JCPjStHgaZsq1bXpM7mqDo_n9LPK5qf4tU1Le=yw@mail.gmail.com>
	<CAAG4q_W1-pAoFH_cX1pYmdyiAb4tyL-bQ3i6hY9-TseJvkYJ=A@mail.gmail.com>
Date: Thu, 16 Oct 2014 10:26:28 -0700
Message-ID: 
 <CALte62yECi3de40Af03NC-nBFm9hi0wJ3Ga02QSnBc1iAXtCUw@mail.gmail.com>
Subject: Re: A Chome extension for rendering patch on JIRA
From: Ted Yu <yuzhihong@gmail.com>
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: multipart/alternative; boundary=089e0149479c78c13505058d8cde

--089e0149479c78c13505058d8cde
Content-Type: text/plain; charset=UTF-8

Verified that everything works well.

Thanks for the fast turn around.

On Thu, Oct 16, 2014 at 10:23 AM, David DENG <daviddengcn@gmail.com> wrote:

> The new version should've solved this problem. Thanks for reporting.
>
> David
>
> On Wed, Oct 15, 2014 at 11:09 AM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > David:
> > Thanks for the new feature.
> >
> > I found a little rendering bug. If you look at the following using your
> > plugin:
> >
> >
> https://issues.apache.org/jira/secure/attachment/12675067/HBASE-12267_v2.patch
> >
> > You would see that the 3rd line below (MultiTableOutputFormat.java):
> > public void close(TaskAttemptContext context) throws IOException { - for
> > (HTable table : tables.values()) { + for (Pair<Connection, Table> pair :
> > tables.values()) {
> >
> > becomes:
> > for (Pair&lt;Connection, Table> pair : tables.values()) {
> >
> > On Tue, Oct 14, 2014 at 10:05 PM, David DENG <daviddengcn@gmail.com>
> > wrote:
> >
> > > Version 1.5 has been submitted. Click on the icon to switch between
> > > original and formatted.
> > >
> > > On Tue, Oct 14, 2014 at 6:43 AM, David DENG <daviddengcn@gmail.com>
> > wrote:
> > >
> > > > I'll make clicks on the icon on toolbar switching between original
> and
> > > > formatted. Couldn't be later than this weekend.
> > > >
> > > > David
> > > >
> > > > On Mon, Oct 13, 2014 at 10:19 PM, tobe <tobeg3oogle@gmail.com>
> wrote:
> > > >
> > > >> I could like to copy the address in Firefox to view the original
> file
> > or
> > > >> just disable the plugin.
> > > >>
> > > >> On Tue, Oct 14, 2014 at 12:08 PM, Ted Yu <yuzhihong@gmail.com>
> wrote:
> > > >>
> > > >> > Sometimes the reviewer may want to reference some particular diff
> in
> > > >> review
> > > >> > comment.
> > > >> >
> > > >> > Is there a way to switch back to viewing the text of the patch ?
> > > >> >
> > > >> > I fully understand that you have other priorities.
> > > >> >
> > > >> > Cheers
> > > >> >
> > > >> > On Sat, Oct 11, 2014 at 9:37 PM, David DENG <
> daviddengcn@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> > > Published a new version of the exteions:
> > > >> > >
> > > >> > > 1. An icon is shown right to the address bar. When viewing patch
> > in
> > > an
> > > >> > > arbitrary url, click on the icon, it'll be rendered. This
> support
> > > >> cause
> > > >> > the
> > > >> > > extension needs a re-enabling when upgraded. (Sorry for the
> > > >> re-enalbing)
> > > >> > >
> > > >> > > 2. Add an option page to set url patterns which are auto
> rendered.
> > > >> > Default
> > > >> > > values are Apache jira patches (added [.]txt pattern)
> > > >> > >
> > > >> > > David
> > > >> > >
> > > >> > > On Fri, Oct 10, 2014 at 6:22 PM, Ted Yu <yuzhihong@gmail.com>
> > > wrote:
> > > >> > >
> > > >> > > > Yes.
> > > >> > > >
> > > >> > > > See https://issues.apache.org/jira/browse/HBASE-12164
> > > >> > > >
> > > >> > > > On Fri, Oct 10, 2014 at 5:58 PM, David DENG <
> > > daviddengcn@gmail.com>
> > > >> > > wrote:
> > > >> > > >
> > > >> > > > > @Ted, people also submit patch with .txt extension?
> > > >> > > > >
> > > >> > > > > David
> > > >> > > > >
> > > >> > > > > On Fri, Oct 10, 2014 at 5:35 PM, Ted Yu <
> yuzhihong@gmail.com>
> > > >> wrote:
> > > >> > > > >
> > > >> > > > > > Interesting.
> > > >> > > > > >
> > > >> > > > > > Can you add the following to the recognized patterns ?
> > > >> > > > > >
> > > >> > > > > > https://issues.apache.org/jira/secure/attachment/*/*.
> > > >> > > > > > <
> https://issues.apache.org/jira/secure/attachment/*/*.patch
> > > >txt
> > > >> > > > > >
> > > >> > > > > > On Fri, Oct 10, 2014 at 4:57 PM, David DENG <
> > > >> daviddengcn@gmail.com
> > > >> > >
> > > >> > > > > wrote:
> > > >> > > > > >
> > > >> > > > > > >
> > > >> > > > > > >
> > > >> > > > > >
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg
> > > >> > > > > > >
> > > >> > > > > > > Go to one of the JIRA patch, the raw text will be
> rendered
> > > as
> > > >> a
> > > >> > > > > > Phabricator
> > > >> > > > > > > like page (Like http://review.facebook.net/ ).
> > > >> > > > > > > Recognized URL pattern:
> > > >> > > > > > >
> > https://issues.apache.org/jira/secure/attachment/*/*.patch
> > > >> > > > > > >
> > > >> > > > > > > Source code and bug report:
> > > >> > > https://github.com/daviddengcn/patch-ext
> > > >> > > > > > >
> > > >> > > > > > > Have a try and enjoy!
> > > >> > > > > > >
> > > >> > > > > > > David
> > > >> > > > > > >
> > > >> > > > > >
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

--089e0149479c78c13505058d8cde--