hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David DENG <davidden...@gmail.com>
Subject Re: A Chome extension for rendering patch on JIRA
Date Mon, 13 Oct 2014 13:36:38 GMT
@tobe I fixed the width assuming the code is generally of maximum 100 chars
per line. Or are you saying that it is too wide so that you have to scroll
horizontally?

David

On Mon, Oct 13, 2014 at 12:31 AM, tobe <tobeg3oogle@gmail.com> wrote:

> The extension is great and it saves me day. But it's not full-screen by
> default when I open a patch. Maybe something related to the resolution.
> Anyway, thanks @david for your work!
>
> On Sun, Oct 12, 2014 at 12:43 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > Thanks for the fast turnaround.
> >
> > I just installed the extension. Viewing patch becomes much pleasant now.
> >
> > Cheers
> >
> > On Sat, Oct 11, 2014 at 9:37 PM, David DENG <daviddengcn@gmail.com>
> wrote:
> >
> > > Published a new version of the exteions:
> > >
> > > 1. An icon is shown right to the address bar. When viewing patch in an
> > > arbitrary url, click on the icon, it'll be rendered. This support cause
> > the
> > > extension needs a re-enabling when upgraded. (Sorry for the
> re-enalbing)
> > >
> > > 2. Add an option page to set url patterns which are auto rendered.
> > Default
> > > values are Apache jira patches (added [.]txt pattern)
> > >
> > > David
> > >
> > > On Fri, Oct 10, 2014 at 6:22 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> > >
> > > > Yes.
> > > >
> > > > See https://issues.apache.org/jira/browse/HBASE-12164
> > > >
> > > > On Fri, Oct 10, 2014 at 5:58 PM, David DENG <daviddengcn@gmail.com>
> > > wrote:
> > > >
> > > > > @Ted, people also submit patch with .txt extension?
> > > > >
> > > > > David
> > > > >
> > > > > On Fri, Oct 10, 2014 at 5:35 PM, Ted Yu <yuzhihong@gmail.com>
> wrote:
> > > > >
> > > > > > Interesting.
> > > > > >
> > > > > > Can you add the following to the recognized patterns ?
> > > > > >
> > > > > > https://issues.apache.org/jira/secure/attachment/*/*.
> > > > > > <https://issues.apache.org/jira/secure/attachment/*/*.patch>txt
> > > > > >
> > > > > > On Fri, Oct 10, 2014 at 4:57 PM, David DENG <
> daviddengcn@gmail.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg
> > > > > > >
> > > > > > > Go to one of the JIRA patch, the raw text will be rendered
as a
> > > > > > Phabricator
> > > > > > > like page (Like http://review.facebook.net/ ).
> > > > > > > Recognized URL pattern:
> > > > > > > https://issues.apache.org/jira/secure/attachment/*/*.patch
> > > > > > >
> > > > > > > Source code and bug report:
> > > https://github.com/daviddengcn/patch-ext
> > > > > > >
> > > > > > > Have a try and enjoy!
> > > > > > >
> > > > > > > David
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message