Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Fri, 19 Sep 2014 18:23:33 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.12742793.1411150966000.79598.1411151013872@Atlassian.JIRA>
In-Reply-To: <JIRA.12742793.1411150966000@Atlassian.JIRA>
References: <JIRA.12742793.1411150966000@Atlassian.JIRA>
 <JIRA.12742793.1411150966349@arcas>
Subject: [jira] [Created] (HBASE-12030) Wrong compaction report and assert
 when MOB compaction switches to minor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Matteo Bertozzi created HBASE-12030:
---------------------------------------

             Summary: Wrong compaction report and assert when MOB compaction switches to minor
                 Key: HBASE-12030
                 URL: https://issues.apache.org/jira/browse/HBASE-12030
             Project: HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: hbase-11339
            Reporter: Matteo Bertozzi
            Priority: Critical
             Fix For: hbase-11339


when zookeeper is down during a major compaction, we switch to a minor.
{code}
try {
  zk = MobZookeeper.newInstance(this.conf, compactionName);
} catch (KeeperException e) {
  LOG.error("Cannot connect to the zookeeper, ready to perform the minor compaction instead", e);
  // change the major compaction into a minor one
  compaction.getRequest().setIsMajor(false);
  return super.compact(compaction);
}
{code}

but the "request start" (HRegion.reportCompactionRequestStart) is "major" and increments the major-compactions counter
while the "request end" (HRegion.reportCompactionRequestEnd) is "minor" and decrements the minor-compactions counter
triggering the assert newValue >= 0, since we are decrementing the wrong counter


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)