Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDCEA11542 for ; Fri, 22 Aug 2014 20:47:51 +0000 (UTC) Received: (qmail 99180 invoked by uid 500); 22 Aug 2014 20:47:51 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 99104 invoked by uid 500); 22 Aug 2014 20:47:51 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 99080 invoked by uid 99); 22 Aug 2014 20:47:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 20:47:50 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates 209.85.215.42 as permitted sender) Received: from [209.85.215.42] (HELO mail-la0-f42.google.com) (209.85.215.42) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 20:47:22 +0000 Received: by mail-la0-f42.google.com with SMTP id pv20so10628114lab.29 for ; Fri, 22 Aug 2014 13:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=LyX5tX2DdIG7hh1y+SLeuyOubRTO6DIDWD2ZywtSams=; b=yW3+iAT2ffX+QfAPcb6fnu/si2/G0Ta80nLTm0e9OoirEPkGMCgq/8bJEOQsl8TYyl Hp1MM2N0F8Zi8ptb7qksTTy0UMj2Ks55OuMjnC1GcsdBHXwvxulbAHj/lvtEVQZql5FU RCYSB4OPILGgsIHqmOBLSkR+3TOLk5MH1dZXfvzlQ3TGQpW95RBfAYqcJhKiep1F1U/D z6R9OqHIZqF31DE9ZSQjD3YktVqvwFMGJQhkOUyt9+UqS45GtwZ81Q0qYEs87QbU8qwl zZv2DZb/a+rqUuXTSPrqIiAZSE+daksW/80S7PUuut6nByXaTbMaCKqwlO6qBerUwgq7 oLyQ== MIME-Version: 1.0 X-Received: by 10.152.28.67 with SMTP id z3mr7008697lag.12.1408740441592; Fri, 22 Aug 2014 13:47:21 -0700 (PDT) Sender: saint.ack@gmail.com Received: by 10.152.148.170 with HTTP; Fri, 22 Aug 2014 13:47:21 -0700 (PDT) In-Reply-To: References: Date: Fri, 22 Aug 2014 13:47:21 -0700 X-Google-Sender-Auth: yY4fhNpuzr8bGozB7GTe2GSavZw Message-ID: Subject: Re: DISCUSSION: 1.0.0 From: Stack To: HBase Dev List Content-Type: multipart/alternative; boundary=089e0158c8d49a185f05013df124 X-Virus-Checked: Checked by ClamAV on apache.org --089e0158c8d49a185f05013df124 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable How we looking for a 0.99.0? I can go review of outstanding issue list np Enis, just say, but you probably have a notion on where we are already. Grand, St.Ack On Tue, Jul 29, 2014 at 2:35 AM, Aditya wrote: > Thanks Ted! > > > On Mon, Jul 28, 2014 at 4:37 PM, Ted Yu wrote: > > > I started with https://reviews.apache.org/r/23175/ > > > > Will continue reviewing this week. > > > > > > On Mon, Jul 28, 2014 at 1:40 PM, Aditya wrote= : > > > >> Did anyone get a chance to take a look at the patches? > >> > >> Regards, > >> aditya... > >> > >> > >> On Sun, Jul 20, 2014 at 8:37 PM, Aditya > wrote: > >> > >> > The wrapper jar is part of the first patch, which is in git mailbox > >> patch > >> > format. > >> > > >> > > >> > On Sat, Jul 19, 2014 at 2:03 AM, Ted Yu wrote: > >> > > >> >> You may want to attach the wrapper jar to the JIRA directly. > >> >> > >> >> Cheers > >> >> > >> >> On Jul 19, 2014, at 1:52 AM, Aditya wrote= : > >> >> > >> >> Looks like the regular patch command skips any binary included in > >> patches. > >> >> > >> >> > >> >> On Sat, Jul 19, 2014 at 1:37 AM, Aditya > >> wrote: > >> >> > >> >>> Thanks for taking a look Ted! > >> >>> > >> >>> Looks like the second patch created with "git diff" excluded the > >> Gradle > >> >>> wrapper JAR from the patch. > >> >>> > >> >>> I would generate a new one which includes this this jar. In the > >> >>> meantime, you should be able to use the first patch attached to th= e > >> JIRA > >> >>> which is in git-am format and that would let you build. > >> >>> > >> >>> > >> >>> On Fri, Jul 18, 2014 at 3:40 PM, Ted Yu > wrote: > >> >>> > >> >>>> Nice work, Aditya. > >> >>>> > >> >>>> Looks like the hbase-native-client profile requires gradle ? > >> >>>> > >> >>>> [exec] Error: Could not find or load main class > >> >>>> org.gradle.wrapper.GradleWrapperMain > >> >>>> > >> >>>> Will take a look at your patch. > >> >>>> > >> >>>> Cheers > >> >>>> > >> >>>> > >> >>>> > >> >>>> On Fri, Jul 18, 2014 at 3:08 PM, Aditya > >> >>>> wrote: > >> >>>> > >> >>>>> As requested, I have attached a combined patch to the umbrella > JIRA > >> >>>>> and submitted > >> it to > >> >>>>> > >> >>>>> jenkins. > >> >>>>> > >> >>>>> Would be great if someone could take a look and provide feedback= . > >> >>>>> > >> >>>>> Regards, > >> >>>>> aditya... > >> >>>>> > >> >>>>> > >> >>>>> On Wed, Jul 9, 2014 at 7:05 PM, Aditya > >> >>>>> wrote: > >> >>>>> > >> >>>>> > I was hoping to get some initial comments before attaching > patches > >> >>>>> for the > >> >>>>> > build boat. > >> >>>>> > > >> >>>>> > I have broken the entire code into 5 patch sets, layered in a > >> >>>>> sequnce, > >> >>>>> > each focusing on a particular area (public headers/JNI > >> >>>>> > implementation/Examples+unit test, etc) for the ease of review= . > >> >>>>> > > >> >>>>> > https://reviews.apache.org/r/23175/ > >> >>>>> > https://reviews.apache.org/r/23176/ > >> >>>>> > https://reviews.apache.org/r/23177/ > >> >>>>> > https://reviews.apache.org/r/23178/ > >> >>>>> > https://reviews.apache.org/r/23179/ > >> >>>>> > > >> >>>>> > These are also available as a sequence of patches as the pull > >> request > >> >>>>> > . > >> >>>>> > >> >>>>> > > >> >>>>> > Only the last patch hooks everything to the HBase build proces= s > >> >>>>> > (optionally) and hence I was thinking of squashing these > separate > >> >>>>> patches > >> >>>>> > into a single patch to be submitted for build. > >> >>>>> > > >> >>>>> > > >> >>>>> > On Wed, Jul 9, 2014 at 11:32 AM, Nick Dimiduk < > ndimiduk@gmail.com > >> > > >> >>>>> wrote: > >> >>>>> > > >> >>>>> >> This ticket has only open subtasks, ie nothing in 'patch > >> >>>>> available'. I > >> >>>>> >> assume you mean HBASE-10168. We'll see about getting you some > >> >>>>> reviews, but > >> >>>>> >> you should also go about formatting the patch for buildbot. > Also, > >> >>>>> since > >> >>>>> >> your 3 reviews are individually 100+k, you should consider > >> breaking > >> >>>>> them > >> >>>>> >> into three separate tickets. > >> >>>>> >> > >> >>>>> >> my 2=C2=A2 > >> >>>>> >> -n > >> >>>>> >> > >> >>>>> >> > >> >>>>> >> On Mon, Jul 7, 2014 at 12:01 PM, Aditya < > adityakishore@gmail.com > >> > > >> >>>>> wrote: > >> >>>>> >> > >> >>>>> >>> Sorry about that. > >> >>>>> >>> > >> >>>>> >>> Here is the umbrella JIRA > >> >>>>> >>> https://issues.apache.org/jira/browse/HBASE-1015 > >> >>>>> >>> > >> >>>>> >>> > >> >>>>> >>> On Mon, Jul 7, 2014 at 10:05 AM, Nick Dimiduk < > >> ndimiduk@gmail.com> > >> >>>>> >>> wrote: > >> >>>>> >>> > >> >>>>> >>>> Would you mind including the JIRA numbers along with the > >> request? > >> >>>>> >>>> > >> >>>>> >>>> Thanks, > >> >>>>> >>>> Nick > >> >>>>> >>>> > >> >>>>> >>>> > >> >>>>> >>>> On Mon, Jul 7, 2014 at 9:52 AM, Aditya < > >> adityakishore@gmail.com> > >> >>>>> wrote: > >> >>>>> >>>> > >> >>>>> >>>>> Do we want to have the C APIs part of 1.0.0 release. I had > >> >>>>> posted few > >> >>>>> >>>>> patches and a set of review request sometime last week. > >> >>>>> >>>>> > >> >>>>> >>>>> > >> >>>>> >>>>> On Fri, Jul 4, 2014 at 1:21 AM, Enis S=C3=B6ztutar < > >> >>>>> enis.soz@gmail.com> > >> >>>>> >>>>> wrote: > >> >>>>> >>>>> > >> >>>>> >>>>> > On Thu, Jul 3, 2014 at 4:41 PM, Mikhail Antonov < > >> >>>>> >>>>> olorinbant@gmail.com> > >> >>>>> >>>>> > wrote: > >> >>>>> >>>>> > > >> >>>>> >>>>> > > Moved ZK watcher & listener subtask out of scope > >> >>>>> HBASE-10909. Enis > >> >>>>> >>>>> - with > >> >>>>> >>>>> > > that, I guess HBASE-10909 can be marked in branch-1? > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > >> >>>>> >>>>> > Sounds good. > >> >>>>> >>>>> > > >> >>>>> >>>>> > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > HBASE-11464 - this is the jira where I'll capture task= s > to > >> >>>>> >>>>> abstract hbase > >> >>>>> >>>>> > > client from ZK (mostly it would be post-1.0 work). > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > >> >>>>> >>>>> > Not sure whether we can make it fully backwards compatib= le > >> >>>>> with 1.0 > >> >>>>> >>>>> > clients. I guess we will see when the patches are done. > >> >>>>> >>>>> > > >> >>>>> >>>>> > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > Thanks, > >> >>>>> >>>>> > > Mikhail > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > 2014-07-03 12:52 GMT-07:00 Stack : > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > > On Thu, Jul 3, 2014 at 12:25 PM, Mikhail Antonov < > >> >>>>> >>>>> olorinbant@gmail.com > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > > wrote: > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > > Guys, > >> >>>>> >>>>> > > > > > >> >>>>> >>>>> > > > > getting back to ZK abstraction work w.r.t. release > 1.0 > >> >>>>> and > >> >>>>> >>>>> > thereafter, > >> >>>>> >>>>> > > > some > >> >>>>> >>>>> > > > > status update. So as we're getting closer to > complete > >> >>>>> >>>>> HBASE-10909, it > >> >>>>> >>>>> > > > looks > >> >>>>> >>>>> > > > > like the steps may be like this: > >> >>>>> >>>>> > > > > > >> >>>>> >>>>> > > > > - there are 2 subtasks out there not closed yet, > one > >> of > >> >>>>> which > >> >>>>> >>>>> is > >> >>>>> >>>>> > about > >> >>>>> >>>>> > > > log > >> >>>>> >>>>> > > > > splitting (and Sergey S has submitted a patch for > >> >>>>> review), > >> >>>>> >>>>> another is > >> >>>>> >>>>> > > > > abstraction of ZK watcher (this is what I've been > >> >>>>> working on > >> >>>>> >>>>> in the > >> >>>>> >>>>> > > > > background; but after sketching the patch it seems > >> like > >> >>>>> >>>>> without being > >> >>>>> >>>>> > > > able > >> >>>>> >>>>> > > > > to modify the control flows and some changes in th= e > >> >>>>> module > >> >>>>> >>>>> structure, > >> >>>>> >>>>> > > > it'd > >> >>>>> >>>>> > > > > be a lot of scaffolding code not really simplifyin= g > >> >>>>> current > >> >>>>> >>>>> code). So > >> >>>>> >>>>> > > I'd > >> >>>>> >>>>> > > > > propose to descope abstraction of ZK watcher jira > >> >>>>> >>>>> (HBASE-11073), > >> >>>>> >>>>> > > namely: > >> >>>>> >>>>> > > > > convert it to top-level JIRA and continue to work = on > >> it > >> >>>>> >>>>> separately; > >> >>>>> >>>>> > > > rename > >> >>>>> >>>>> > > > > HBASE-10909 to "ZK abstraction: phase 1", and mark > it > >> as > >> >>>>> >>>>> closed as > >> >>>>> >>>>> > soon > >> >>>>> >>>>> > > > as > >> >>>>> >>>>> > > > > log splitting jira is completed. This way > HBASE-10909 > >> >>>>> fits to > >> >>>>> >>>>> > branch-1. > >> >>>>> >>>>> > > > > > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > Sounds good to me. > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > > - secondly, in the discussion to the CatalogTrack= er > >> >>>>> patch, we > >> >>>>> >>>>> > started > >> >>>>> >>>>> > > > > talking about modifying client to not know about Z= K, > >> but > >> >>>>> >>>>> rather keep > >> >>>>> >>>>> > > the > >> >>>>> >>>>> > > > > location of current masters and talk to them using > RPC > >> >>>>> calls. > >> >>>>> >>>>> This > >> >>>>> >>>>> > work > >> >>>>> >>>>> > > > can > >> >>>>> >>>>> > > > > not go into branch-1, as it involves invasive > changes > >> in > >> >>>>> client > >> >>>>> >>>>> > > including > >> >>>>> >>>>> > > > > new RPC. As I understand the branching schema now, > >> those > >> >>>>> >>>>> changes can > >> >>>>> >>>>> > go > >> >>>>> >>>>> > > > to > >> >>>>> >>>>> > > > > master branch, we just don't merge them to branch-= 1, > >> and > >> >>>>> >>>>> depending on > >> >>>>> >>>>> > > > their > >> >>>>> >>>>> > > > > completeness we can pull them to 1.1 release or so= . > >> >>>>> >>>>> > > > > > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > You have it right Mikhail. > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > St.Ack > >> >>>>> >>>>> > > > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > -- > >> >>>>> >>>>> > > Thanks, > >> >>>>> >>>>> > > Michael Antonov > >> >>>>> >>>>> > > > >> >>>>> >>>>> > > >> >>>>> >>>>> > >> >>>>> >>>> > >> >>>>> >>>> > >> >>>>> >>> > >> >>>>> >> > >> >>>>> > > >> >>>>> > >> >>>> > >> >>>> > >> >>> > >> >> > >> > > >> > > > > > --089e0158c8d49a185f05013df124--