hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Dimiduk <ndimi...@gmail.com>
Subject Re: [DISCUSSION] applying patches
Date Fri, 01 Aug 2014 18:09:40 GMT
Apparently the signoff feature was added for the benefit of Linux's
"Certificate of Origin" requirements. By using the same mechanism, are we
implying that we follow the same guidelines in its use? I don't think it's
common for a committer to assert the OSS validity of the contribution, or
that the contributor has completed the Apache ICLA.

http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html


On Fri, Aug 1, 2014 at 11:01 AM, Nick Dimiduk <ndimiduk@gmail.com> wrote:

> Can we enforce the use of --signoff with a hook? If author email isn't @
> apache.org then signoff stamp is required, something like this?
>
>
> On Fri, Aug 1, 2014 at 10:53 AM, Mike Drob <madrob@cloudera.com> wrote:
>
>> It's a little more work, but without the sign-off line you can still find
>> the committer by doing "git log --formate=full"
>>
>> Mike
>>
>>
>> On Fri, Aug 1, 2014 at 12:43 PM, Andrew Purtell <apurtell@apache.org>
>> wrote:
>>
>> > I noticed that commit and just sent something to private@ :-) I think
>> it's
>> > a fine practice, but there is no sign off line on that commit so the
>> > committer is not apparent. As long as we can know who committed the
>> patch
>> > at a glance it sounds good to me.
>> >
>> >
>> > On Fri, Aug 1, 2014 at 10:38 AM, Stack <stack@duboce.net> wrote:
>> >
>> > > I just committed a message with 'git am' because the author took the
>> > > trouble to write a sweet commit message. Others have been taking the
>> > > trouble to write useful commit messages but up to this I've been just
>> > > applying patches with patch with a commit message that is the issue
>> > number,
>> > > subject, and author only rather than git apply or git am.
>> > >
>> > > On the tail of HBASE-4593, Misty is looking for clarification.
>> > >
>> > > I suggest that if contributor wrote a nice commit message that leads
>> off
>> > > with issue number and issue subject, going forward, we preserve their
>> > work
>> > > and apply using git am --signoff?
>> > >
>> > > You cowboys and cowgirls have any opinions?
>> > > St.Ack
>> > >
>> >
>> >
>> >
>> > --
>> > Best regards,
>> >
>> >    - Andy
>> >
>> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
>> > (via Tom White)
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message