hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Dimiduk <ndimi...@gmail.com>
Subject Re: adding a profile to build thrift generated classes
Date Fri, 01 Aug 2014 00:27:34 GMT
So long as you can enforce that the thrift binary version matches whatever
the pom.xml requires, it's fine by me. You want to cook up a patch, Sean?


On Wed, Jul 30, 2014 at 11:12 PM, Srikanth Srungarapu <srikanth235@gmail.com
> wrote:

> +1 on the idea. Currently, there is a profile for generating protobuf files
> (http://hbase.apache.org/book/build.html), but I couldn't find any analog
> for thrift. So, this can come handy when needed.
>
>
> On Wed, Jul 30, 2014 at 10:47 PM, Sean Busbey <busbey@cloudera.com> wrote:
>
> > Hiya!
> >
> > Currently, the only instructions for generating our RPC classes via
> thrift
> > that I can find are in a package javadoc[1].
> >
> > While I doubt we rebuild them very often, I was thinking we could ease
> the
> > process by adding a maven profile that took care of the rebuilding and
> > copying into place.
> >
> > It would still require having thrift installed on the build system, so it
> > would need to be disabled by default.
> >
> > Wanted to check for concerns / objections before filing a jira.
> >
> > [1]: http://s.apache.org/hZv
> >
> > --
> > Sean
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message