hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: [DISCUSSION] applying patches
Date Fri, 01 Aug 2014 17:43:20 GMT
I noticed that commit and just sent something to private@ :-) I think it's
a fine practice, but there is no sign off line on that commit so the
committer is not apparent. As long as we can know who committed the patch
at a glance it sounds good to me.

On Fri, Aug 1, 2014 at 10:38 AM, Stack <stack@duboce.net> wrote:

> I just committed a message with 'git am' because the author took the
> trouble to write a sweet commit message. Others have been taking the
> trouble to write useful commit messages but up to this I've been just
> applying patches with patch with a commit message that is the issue number,
> subject, and author only rather than git apply or git am.
> On the tail of HBASE-4593, Misty is looking for clarification.
> I suggest that if contributor wrote a nice commit message that leads off
> with issue number and issue subject, going forward, we preserve their work
> and apply using git am --signoff?
> You cowboys and cowgirls have any opinions?
> St.Ack

Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message