Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF3F410B31 for ; Fri, 25 Jul 2014 19:42:39 +0000 (UTC) Received: (qmail 30480 invoked by uid 500); 25 Jul 2014 19:42:39 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 30384 invoked by uid 500); 25 Jul 2014 19:42:39 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 30365 invoked by uid 99); 25 Jul 2014 19:42:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jul 2014 19:42:38 +0000 Date: Fri, 25 Jul 2014 19:42:38 +0000 (UTC) From: "Jean-Daniel Cryans (JIRA)" To: dev@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Daniel Cryans resolved HBASE-11388. ---------------------------------------- Resolution: Fixed Fix Version/s: (was: 0.99.0) Hadoop Flags: Reviewed You're right, so I just pushed to patch to 0.98. Thanks! > The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl > --------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-11388 > URL: https://issues.apache.org/jira/browse/HBASE-11388 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 0.99.0, 0.98.3 > Reporter: Qianxi Zhang > Assignee: Qianxi Zhang > Priority: Minor > Fix For: 0.98.5 > > Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch > > > The parameters is "Configurationi", "ClusterKey" and "id" in the constructor of the class ReplicationPeer. But he order parameter is "Configurationi", "id" and "ClusterKey" when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl > ReplicationPeer#76 > {code} > public ReplicationPeer(Configuration conf, String key, String id) throws ReplicationException { > this.conf = conf; > this.clusterKey = key; > this.id = id; > try { > this.reloadZkWatcher(); > } catch (IOException e) { > throw new ReplicationException("Error connecting to peer cluster with peerId=" + id, e); > } > } > {code} > ReplicationPeersZKImpl#498 > {code} > ReplicationPeer peer = > new ReplicationPeer(peerConf, peerId, ZKUtil.getZooKeeperClusterKey(peerConf)); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)