Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Sun, 8 Jun 2014 18:18:01 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.12719033.1402172688329.89896.1402251481825@arcas>
In-Reply-To: <JIRA.12719033.1402172688329@arcas>
References: <JIRA.12719033.1402172688329@arcas>
Subject: [jira] [Resolved] (HBASE-11308) Reuse NameStringPair#Builder
 instances in loops
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell resolved HBASE-11308.
------------------------------------

    Resolution: Won't Fix

This is a premature (or never mature) optimization. These calls aren't on hot code paths.

> Reuse NameStringPair#Builder instances in loops
> -----------------------------------------------
>
>                 Key: HBASE-11308
>                 URL: https://issues.apache.org/jira/browse/HBASE-11308
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Priority: Trivial
>
> The following code is from HColumnDescriptor#convert() but the pattern can be found in other classes, such as HBaseAdmin:
> {code}
>     for (Map.Entry<String, String> e : this.configuration.entrySet()) {
>       NameStringPair.Builder aBuilder = NameStringPair.newBuilder();
>       aBuilder.setName(e.getKey());
>       aBuilder.setValue(e.getValue());
>       builder.addConfiguration(aBuilder.build());
>     }
> {code}
> NameStringPair.Builder instance can be reused across iterations of the loop.
> This would save creation of short-lived objects.


--
This message was sent by Atlassian JIRA
(v6.2#6252)