Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Sat, 7 Jun 2014 20:25:01 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.12719033.1402172688329.88271.1402172701901@arcas>
In-Reply-To: <JIRA.12719033.1402172688329@arcas>
References: <JIRA.12719033.1402172688329@arcas>
Subject: [jira] [Created] (HBASE-11308) Reuse NameStringPair#Builder
 instances in loops
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Ted Yu created HBASE-11308:
------------------------------

             Summary: Reuse NameStringPair#Builder instances in loops
                 Key: HBASE-11308
                 URL: https://issues.apache.org/jira/browse/HBASE-11308
             Project: HBase
          Issue Type: Task
            Reporter: Ted Yu
            Priority: Minor


The following code is from HColumnDescriptor#convert() but the pattern can be found in other classes, such as HBaseAdmin:
{code}
    for (Map.Entry<String, String> e : this.configuration.entrySet()) {
      NameStringPair.Builder aBuilder = NameStringPair.newBuilder();
      aBuilder.setName(e.getKey());
      aBuilder.setValue(e.getValue());
      builder.addConfiguration(aBuilder.build());
    }
{code}
NameStringPair.Builder instance can be reused across iterations of the loop.
This would save creation of short-lived objects.


--
This message was sent by Atlassian JIRA
(v6.2#6252)