hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qianxi Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-11342) The method isChildReadLock in class ZKInterProcessLockBase is wrong
Date Fri, 13 Jun 2014 11:41:02 GMT
Qianxi Zhang created HBASE-11342:
------------------------------------

             Summary: The method isChildReadLock in class ZKInterProcessLockBase is wrong
                 Key: HBASE-11342
                 URL: https://issues.apache.org/jira/browse/HBASE-11342
             Project: HBase
          Issue Type: Bug
          Components: Zookeeper
    Affects Versions: 0.98.3, 0.99.0
            Reporter: Qianxi Zhang
            Assignee: Qianxi Zhang
            Priority: Minor


The method isChildReadLock in class ZKInterProcessLockBase may be wrong, which determines
whether the lock is readLock or not. So we should compare the node name with READ_LOCK_CHILD_NODE_PREFIX
rather than WRITE_LOCK_CHILD_NODE_PREFIX. Since there is no other method to invoke the method
"isChildReadLock" now, we have not encountered an error.
{code}
  protected static boolean isChildReadLock(String child) {
    int idx = child.lastIndexOf(ZKUtil.ZNODE_PATH_SEPARATOR);
    String suffix = child.substring(idx + 1);
    return suffix.startsWith(WRITE_LOCK_CHILD_NODE_PREFIX);
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message