hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-11318) Classes in security subpackages missing @InterfaceAudience annotations.
Date Tue, 10 Jun 2014 16:09:05 GMT
Jonathan Hsieh created HBASE-11318:
--------------------------------------

             Summary: Classes in security subpackages missing @InterfaceAudience annotations.
                 Key: HBASE-11318
                 URL: https://issues.apache.org/jira/browse/HBASE-11318
             Project: HBase
          Issue Type: Bug
          Components: security
    Affects Versions: 0.98.3, 0.96.1.1, 0.99.0
            Reporter: Jonathan Hsieh
            Assignee: Jonathan Hsieh
             Fix For: 0.99.0, 0.98.4


I was reading some of the security related code and noticed that many of the security related
classes lack @InterfaceAudience markings.

WIth the current api I believe all but Permission should be Private.  With the introduction
of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL
calls[1].  

There is an inconsistency with the Mutation ACL -- the acl setters take Permission instances
but the getter returns byte[]'s the setters.  As a follow on issue we could change the signature
of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[],
or change the getter to return an exposed Permission instance.

[1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message