hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-11308) Reuse NameStringPair#Builder instances in loops
Date Sat, 07 Jun 2014 20:25:01 GMT
Ted Yu created HBASE-11308:
------------------------------

             Summary: Reuse NameStringPair#Builder instances in loops
                 Key: HBASE-11308
                 URL: https://issues.apache.org/jira/browse/HBASE-11308
             Project: HBase
          Issue Type: Task
            Reporter: Ted Yu
            Priority: Minor


The following code is from HColumnDescriptor#convert() but the pattern can be found in other
classes, such as HBaseAdmin:
{code}
    for (Map.Entry<String, String> e : this.configuration.entrySet()) {
      NameStringPair.Builder aBuilder = NameStringPair.newBuilder();
      aBuilder.setName(e.getKey());
      aBuilder.setValue(e.getValue());
      builder.addConfiguration(aBuilder.build());
    }
{code}
NameStringPair.Builder instance can be reused across iterations of the loop.
This would save creation of short-lived objects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message