hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Marc Spaggiari <jean-m...@spaggiari.org>
Subject Re: Anyone to have a quick look at 11313?
Date Wed, 11 Jun 2014 15:52:52 GMT
Thanks for looking at it Jon.

I will close and open a new one for Reusable and ThreadLocal
removal/deprecation.

JM


2014-06-11 11:13 GMT-04:00 Jonathan Hsieh <jon@cloudera.com>:

> I took a look.  While the patch is trivial enough,  I think we should do
> something do something more drastic.  We should deprecate/remove Reusable
> and Threadlocal PoolMaps for the rpc clients.   Reusable PoolMap in
> conjunction with the code becomes resource unbounded and ThreadLocal is
> tricky to use (difficult to close or interrupt since we have to hunt down
> all the threads).
>
> For now we should deprecate the other two and once 1.0 gets branched we
> should remove Reusable and Threadlocal and possibly just get rid of the
> extra config infrastructure.
>
> Jon.
>
>
> On Tue, Jun 10, 2014 at 5:27 PM, Jean-Marc Spaggiari <
> jean-marc@spaggiari.org> wrote:
>
> > Hi Konstantin, I'm talking about this one:
> > https://issues.apache.org/jira/browse/HBASE-11313
> >
> > Thanks,
> >
> > JM
> >
> >
> > 2014-06-10 20:14 GMT-04:00 Konstantin Boudnik <cos@apache.org>:
> >
> > > Seems to be a private one? Unless I am not in the correct group or
> > > something...
> > >
> > > On Tue, Jun 10, 2014 at 07:58PM, Jean-Marc Spaggiari wrote:
> > > > Pretty trivial patch.
> > > >
> > > > Thanks,
> > > >
> > > > JM
> > >
> >
>
>
>
> --
> // Jonathan Hsieh (shay)
> // HBase Tech Lead, Software Engineer, Cloudera
> // jon@cloudera.com // @jmhsieh
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message