Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Fri, 16 May 2014 11:12:41 +0000 (UTC)
From: "sunjingtao (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.12714689.1400205197609.364681.1400238761387@arcas>
In-Reply-To: <JIRA.12714689.1400205197609@arcas>
References: <JIRA.12714689.1400205197609@arcas>
Subject: [jira] [Created] (HBASE-11192) HBase ClusterId File Empty Check
 Loggic
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

sunjingtao created HBASE-11192:
----------------------------------

             Summary: HBase ClusterId File Empty Check Loggic
                 Key: HBASE-11192
                 URL: https://issues.apache.org/jira/browse/HBASE-11192
             Project: HBase
          Issue Type: Bug
         Environment: HBase 0.94+Hadoop2.2.0+Zookeeper3.4.5
            Reporter: sunjingtao


if the clusterid file exists but empty ,then the following check logic in the MasterFileSystem.java has none effects.
    if (!FSUtils.checkClusterIdExists(fs, rd, c.getInt(
        HConstants.THREAD_WAKE_FREQUENCY, 10 * 1000))) {
          FSUtils.setClusterId(fs, rd, UUID.randomUUID().toString(), c.getInt(
          HConstants.THREAD_WAKE_FREQUENCY, 10 * 1000));
    }
    clusterId = FSUtils.getClusterId(fs, rd);
because the checkClusterIdExists method only check the path .
        Path filePath = new Path(rootdir, HConstants.CLUSTER_ID_FILE_NAME);
        return fs.exists(filePath);

in my case ,the file exists but is empty,so the readed clusterid is null which cause a nullPointerException:

java.lang.NullPointerException
	at org.apache.hadoop.hbase.util.Bytes.toBytes(Bytes.java:441)
	at org.apache.hadoop.hbase.zookeeper.ClusterId.setClusterId(ClusterId.java:72)
	at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:581)
	at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:433)
	at java.lang.Thread.run(Thread.java:745)

is this a bug?please make sure!


--
This message was sent by Atlassian JIRA
(v6.2#6252)