hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-11210) Consider restoring Filter class back to an interface
Date Sat, 24 May 2014 23:37:01 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack resolved HBASE-11210.

    Resolution: Invalid

bq. I am expecting Lars Hofhansl to comment on this issue.

Resolving as invalid. The filer expects someone else is to provide justification (see above)
OR, the justification is some larger project around hasFilterRow that HBASE-10965 is related
to. And this is after two petitions by two separate committers trying to get clarity around
why this issue needs to exist.

> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>                 Key: HBASE-11210
>                 URL: https://issues.apache.org/jira/browse/HBASE-11210
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
>  * Interface for row and column filters directly applied within the regionserver.
> ...
>  * When implementing your own filters, consider inheriting {@link FilterBase} to help
>  * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> Lars first brought up this notion:
> https://issues.apache.org/jira/browse/HBASE-6657?focusedCommentId=13456317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456317
> This gives users / developers clear suggestion that custom filters should override FilterBase
instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.

This message was sent by Atlassian JIRA

View raw message