hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-2597) Use "Builder" pattern instead of many-argument constructors
Date Mon, 12 May 2014 00:41:15 GMT

     [ https://issues.apache.org/jira/browse/HBASE-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell resolved HBASE-2597.
-----------------------------------

    Resolution: Won't Fix
      Assignee:     (was: Todd Lipcon)

Not going to happen. Could reopen if there is active interest (aka a patch soon forthcoming)

> Use "Builder" pattern instead of many-argument constructors
> -----------------------------------------------------------
>
>                 Key: HBASE-2597
>                 URL: https://issues.apache.org/jira/browse/HBASE-2597
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Todd Lipcon
>
> We've got a lot of objects that have a ton of different constructors with a huge number
of parameters. Whenever we add a new parameter, existing callers break, and it's sometimes
difficult to keep track of which booleans/nulls correspond to which parameter.
> I'd like to consider moving to the "Builder" pattern in some of these cases. See http://guava-libraries.googlecode.com/svn/trunk/javadoc/com/google/common/collect/MapMaker.html
for an example of this pattern in action. Another good example is the builder API generated
by protocol buffers (search for "builder" on http://code.google.com/apis/protocolbuffers/docs/javatutorial.html
)
> I think this pattern makes code more readable and also allows us to more easily change
around the number of arguments in our constructors.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message