Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 209.85.213.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <OF8DCAC10C.8D349694-ON87257CBC.005F5B00-88257CBC.005F7C29@us.ibm.com>
References: 
 <OF8DCAC10C.8D349694-ON87257CBC.005F5B00-88257CBC.005F7C29@us.ibm.com>
Date: Wed, 16 Apr 2014 10:30:58 -0700
Message-ID: 
 <CALte62zoyEXDOQOBgNG14BXUWo3dRu5keq6B269gTMwxmvXhvg@mail.gmail.com>
Subject: Re: Question about Writing Unit Tests for JIRA 10950
From: Ted Yu <yuzhihong@gmail.com>
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: multipart/alternative; boundary=089e013a149e9d62e904f72c477b

--089e013a149e9d62e904f72c477b
Content-Type: text/plain; charset=UTF-8

There is no patch posted so I don't know what classes you're modifying.

If the changes are mostly in hbase-client module, the test(s) should be in
the same module.

w.r.t. Configuration, you can obtain it using the following code where
TEST_UTIL is an instance of HBaseTestingUtility:

    Configuration conf = TEST_UTIL.getConfiguration();

Refer to existing tests such as TestFromClientSide

Cheers


On Wed, Apr 16, 2014 at 10:22 AM, Enoch Hsu <ehsu@us.ibm.com> wrote:

>
> Hi All,
>
> I am looking into JIRA 10950 and I have a couple questions about writing
> unit tests for the patch.
> Where should the unit tests go in terms of module and package location?
> e.g. hbase-server, hbase-client, etc
>
> Another thing I observed while trying to write unit tests is that
> HBaseTestingUtility has its own configuration files
> that are used once the minicluster is started, and, unless I pass the
> minicluster's configuration file to my code,
> any new Configuration() calls will not get the same configuration as the
> minicluster.
> Is there any way to get HBaseTestingUtility and HBaseConfiguration.create()
> to interact with each other without passing the conf object around?
> Or is there another way I should be going about writing unit tests for
> this?
>
> Thanks,
> Enoch Hsu

--089e013a149e9d62e904f72c477b--