hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-10968) Null check in TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is redundant
Date Sat, 12 Apr 2014 01:11:14 GMT
Ted Yu created HBASE-10968:
------------------------------

             Summary: Null check in TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize()
is redundant
                 Key: HBASE-10968
                 URL: https://issues.apache.org/jira/browse/HBASE-10968
             Project: HBase
          Issue Type: Bug
            Reporter: Ted Yu


Here is related code:
{code}
    public void initialize(InputSplit split, TaskAttemptContext context) throws IOException,
        InterruptedException {

      Configuration conf = context.getConfiguration();
...
      if (context != null) {
        this.context = context;
        getCounter = TableRecordReaderImpl.retrieveGetCounterWithStringsParams(context);
      }
{code}
context was dereferenced first, leaving the null check ineffective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message