hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: coprocessor stop method not invoked
Date Mon, 28 Apr 2014 12:53:36 GMT
Qiang:
You can open a JIRA and attach your patch. 

Cheers

On Apr 28, 2014, at 3:07 AM, qiang tian <tianq01@gmail.com> wrote:

> Hi Guys,
> I am investigating a customized JMX agent fix based on coprocessor for
> hbase-10289. ---coprocessor makes the fix pluggable so user can switch to
> official JDK7 fix in future easily.
> 
> but I find with the fix the hbase fails to be stopped,  because the tcp
> port is not closed ---the coprocessor stop method is never invoked.
> 
> checking the code, it looks we miss the stop method? and the coprocessor
> examples code in hbase source tree ALL use empty stop method...so it would
> be a problem if coprocessor allocate OS resources such as file handle, tcp
> port?
> 
> I verified adding the stop method invocation fixes the issue.
> can you please let me know if jira is needed?
> 
> thanks.
> Qiang

Mime
View raw message