Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of yuzhihong@gmail.com designates
 209.85.160.41 as permitted sender)
References: <CF3215A5.1BE1A%jzhong@hortonworks.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CF3215A5.1BE1A%jzhong@hortonworks.com>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-Id: <815ABE7F-624C-4219-A3FD-445146A4269E@gmail.com>
Cc: "<dev@hbase.apache.org>" <dev@hbase.apache.org>
From: Ted Yu <yuzhihong@gmail.com>
Subject: Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase
Date: Wed, 26 Feb 2014 06:15:21 -0800
To: "dev@hbase.apache.org" <dev@hbase.apache.org>

I have creates HBASE-10609 and attached a patch there.=20

Cheers

On Feb 25, 2014, at 9:42 AM, Jeffrey Zhong <jzhong@hortonworks.com> wrote:

> I see. As long as we don=C2=B9t remove the function, it should be fine.
>=20
> Thanks,
> -Jeffrey=20
>=20
> On 2/24/14 6:10 PM, "Ted Yu" <yuzhihong@gmail.com> wrote:
>=20
>> bq. filterKeyValue is part of public/Stable Filter interface
>>=20
>> As I mentioned in my first email:
>> FilterBase.java has been marked @InterfaceAudience.Private since 0.96
>>=20
>> Client Filters are free to override filterKeyValue(Cell ignored) in their=

>> implementation.
>>=20
>> Cheers
>>=20
>>=20
>> On Mon, Feb 24, 2014 at 5:52 PM, Jeffrey Zhong
>> <jzhong@hortonworks.com>wrote:
>>=20
>>>=20
>>> filterKeyValue is part of public/Stable Filter interface.
>>>=20
>>> For example, Phoenix use filterKeyValue in many places. I guess there
>>> are
>>> other hbase applications implements filters with this
>>> function.Therefore,
>>> it will break compatibilities for some applications so it's better we
>>> can
>>> firstly desecrated this function and remove it in later major release.
>>>=20
>>>=20
>>> Thanks,
>>> -Jeffrey
>>>=20
>>> On 2/24/14 5:33 PM, "Ted Yu" <yuzhihong@gmail.com> wrote:
>>>=20
>>>> Thanks for the confirmation, Lars.
>>>>=20
>>>> Will wait for a few days before opening JIRA.
>>>>=20
>>>>=20
>>>> On Mon, Feb 24, 2014 at 4:19 PM, lars hofhansl <larsh@apache.org>
>>> wrote:
>>>>=20
>>>>> Let's remove it and add adequate documentation. It has been the
>>> source
>>>>> of
>>>>> too many problems.
>>>>>=20
>>>>> If filterRowKey returns true filterKeyValue needs to be consistent
>>> with
>>>>> it.
>>>>> filterKeyValue can assume that filterRowKey has already been called
>>> for
>>>>> the row.
>>>>>=20
>>>>> -- Lars
>>>>>=20
>>>>>=20
>>>>>=20
>>>>> ________________________________
>>>>> From: Ted Yu <yuzhihong@gmail.com>
>>>>> To: "dev@hbase.apache.org" <dev@hbase.apache.org>
>>>>> Sent: Monday, February 24, 2014 9:44 AM
>>>>> Subject: Discussion: dropping filterKeyValue(Cell ignored) from
>>>>> FilterBase
>>>>>=20
>>>>>=20
>>>>> Hi,
>>>>> FilterBase.java has been marked @InterfaceAudience.Private since 0.96
>>>>> I want to get your opinion on making potential change to FilterBase -
>>>>> dropping filterKeyValue(Cell ignored).
>>>>>=20
>>>>> You can find background in HBASE-10485: PrefixFilter#filterKeyValue()
>>>>> should perform filtering on row key
>>>>>=20
>>>>> My thinking is that dropping filterKeyValue(Cell ignored) would let
>>>>> developers make conscientious decision on when ReturnCode.INCLUDE
>>>>> should be
>>>>> returned.
>>>>> This is for 0.99 only.
>>>>>=20
>>>>> Your opinion is appreciated.
>>>>>=20
>>>>> Thanks
>>>=20
>>>=20
>>>=20
>>> --
>>> CONFIDENTIALITY NOTICE
>>> NOTICE: This message is intended for the use of the individual or
>>> entity to
>>> which it is addressed and may contain information that is confidential,
>>> privileged and exempt from disclosure under applicable law. If the
>>> reader
>>> of this message is not the intended recipient, you are hereby notified
>>> that
>>> any printing, copying, dissemination, distribution, disclosure or
>>> forwarding of this communication is strictly prohibited. If you have
>>> received this communication in error, please contact the sender
>>> immediately
>>> and delete it from your system. Thank You.
>=20
>=20
>=20
> --=20
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity t=
o=20
> which it is addressed and may contain information that is confidential,=20=

> privileged and exempt from disclosure under applicable law. If the reader=20=

> of this message is not the intended recipient, you are hereby notified tha=
t=20
> any printing, copying, dissemination, distribution, disclosure or=20
> forwarding of this communication is strictly prohibited. If you have=20
> received this communication in error, please contact the sender immediatel=
y=20
> and delete it from your system. Thank You.