hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-10604) Fix parseArgs javadoc
Date Tue, 25 Feb 2014 13:32:19 GMT
Jean-Marc Spaggiari created HBASE-10604:
-------------------------------------------

             Summary: Fix parseArgs javadoc
                 Key: HBASE-10604
                 URL: https://issues.apache.org/jira/browse/HBASE-10604
             Project: HBase
          Issue Type: Bug
            Reporter: Jean-Marc Spaggiari
            Assignee: Jean-Marc Spaggiari
            Priority: Minor


Javadoc for parseArgs is a cut&past of previous method and need to be fixed.

{code}
  /*
   * Adds a region's meta information from the passed <code>meta</code>
   * region.
   *
   * @param metainfo hbase:meta HRegionInfo to be updated
   * @param region HRegion to add to <code>meta</code>
   *
   * @throws IOException
   */
  private int parseArgs(String[] args) throws IOException {
    GenericOptionsParser parser =
      new GenericOptionsParser(getConf(), args);

    String[] remainingArgs = parser.getRemainingArgs();
    if (remainingArgs.length != 3) {
      usage();
      return -1;
    }
    tableName = TableName.valueOf(remainingArgs[0]);

    region1 = Bytes.toBytesBinary(remainingArgs[1]);
    region2 = Bytes.toBytesBinary(remainingArgs[2]);
    int status = 0;
    if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
      status = -1;
    } else if (Bytes.equals(region1, region2)) {
      LOG.error("Can't merge a region with itself");
      status = -1;
    }
    return status;
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message