hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase
Date Tue, 25 Feb 2014 01:33:01 GMT
Thanks for the confirmation, Lars.

Will wait for a few days before opening JIRA.


On Mon, Feb 24, 2014 at 4:19 PM, lars hofhansl <larsh@apache.org> wrote:

> Let's remove it and add adequate documentation. It has been the source of
> too many problems.
>
> If filterRowKey returns true filterKeyValue needs to be consistent with it.
> filterKeyValue can assume that filterRowKey has already been called for
> the row.
>
> -- Lars
>
>
>
> ________________________________
>  From: Ted Yu <yuzhihong@gmail.com>
> To: "dev@hbase.apache.org" <dev@hbase.apache.org>
> Sent: Monday, February 24, 2014 9:44 AM
> Subject: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase
>
>
> Hi,
> FilterBase.java has been marked @InterfaceAudience.Private since 0.96
> I want to get your opinion on making potential change to FilterBase -
> dropping filterKeyValue(Cell ignored).
>
> You can find background in HBASE-10485: PrefixFilter#filterKeyValue()
> should perform filtering on row key
>
> My thinking is that dropping filterKeyValue(Cell ignored) would let
> developers make conscientious decision on when ReturnCode.INCLUDE should be
> returned.
> This is for 0.99 only.
>
> Your opinion is appreciated.
>
> Thanks

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message