Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C5E51098E for ; Tue, 21 Jan 2014 00:43:02 +0000 (UTC) Received: (qmail 20191 invoked by uid 500); 21 Jan 2014 00:43:00 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 20032 invoked by uid 500); 21 Jan 2014 00:42:59 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 20024 invoked by uid 99); 21 Jan 2014 00:42:59 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2014 00:42:59 +0000 Received: from localhost (HELO mail-we0-f182.google.com) (127.0.0.1) (smtp-auth username apurtell, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2014 00:42:59 +0000 Received: by mail-we0-f182.google.com with SMTP id w62so7602121wes.13 for ; Mon, 20 Jan 2014 16:42:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=TMucCexfsgUBLl+g8RQ1RHumkA6M0QBrP3BGszH2vFw=; b=ZpTTvJDsLVWC+lTHWmLoFO/2GzmG0ktFw6HPL1bRwpVcBfHbaubI1Bx0z8/WVIm0FQ oFGI1g+qT0MrmPYYzEQnlgGi1Hvq4GI8cJnSZjoW2eVoSKAc7jYQqenQo6YwbJoKWIMZ iGZV43Kgf5apbBiK33al5c4y6AzxGnLMvFTh0HSXLoUevIF+1TOcyOIDoawB+Z8eY6zW pGyuImgEOJW1JDettPlnIryzsUtTWFFhSixNoEM4mZfNSqf41V///Po2xkxhpLx8E0g8 7q3WwuH7YlT+4nAztwocSmxjiTesmD+KoNJ26iCkWQSFDWaVbnHbMwla+TFXn6g+tjzA HivQ== X-Received: by 10.194.234.65 with SMTP id uc1mr16558084wjc.39.1390264977427; Mon, 20 Jan 2014 16:42:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.227.152.8 with HTTP; Mon, 20 Jan 2014 16:42:17 -0800 (PST) In-Reply-To: References: From: Andrew Purtell Date: Mon, 20 Jan 2014 16:42:17 -0800 Message-ID: Subject: Re: Are we no longer giving credit in SVN commit messages? To: "dev@hbase.apache.org" Content-Type: multipart/alternative; boundary=089e01419e1e1f955e04f0704a67 --089e01419e1e1f955e04f0704a67 Content-Type: text/plain; charset=ISO-8859-1 Thanks for that. I agree there's no point to attribute your own code to yourself :-) but that committing someone else's work without attribution in the commit log is in my view taking credit for their work. Just my opinion. On Mon, Jan 20, 2014 at 4:39 PM, Jesse Yates wrote: > +1 To continue giving attribution (unless you wrote the code, in which > case, whats the point, eh?) > > ------------------- > Jesse Yates > @jesse_yates > jyates.github.com > > > On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell > wrote: > > > I see some committers are continuing the informal practice we've had of > > attribution in parenthesis after the issue description if the work is not > > your own, e.g. > > > > HBASE-XXXX. JIRA title goes here (Contributor Name) > > > > I've noticed that some committers are definitely not doing this. > > > > I think it is bad practice not to provide attribution to the contributor > in > > the commit message. When one is reviewing commit history, neither links > to > > JIRA nor inlining of JIRA content is possible -- unless there is some > tool > > that does this of which I'm not aware (please let me know!). > > > > -- > > Best regards, > > > > - Andy > > > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > > (via Tom White) > > > -- Best regards, - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White) --089e01419e1e1f955e04f0704a67--