hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-10294) Some synchronization on ServerManager#onlineServers can be removed
Date Wed, 08 Jan 2014 00:03:53 GMT
Ted Yu created HBASE-10294:
------------------------------

             Summary: Some synchronization on ServerManager#onlineServers can be removed
                 Key: HBASE-10294
                 URL: https://issues.apache.org/jira/browse/HBASE-10294
             Project: HBase
          Issue Type: Task
            Reporter: Ted Yu
            Priority: Minor


ServerManager#onlineServers is a ConcurrentHashMap

Yet I found that some accesses to it are synchronized and unnecessary.
Here is one example:
{code}
  public Map<ServerName, ServerLoad> getOnlineServers() {
    // Presumption is that iterating the returned Map is OK.
    synchronized (this.onlineServers) {
      return Collections.unmodifiableMap(this.onlineServers);
{code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message