hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Are we no longer giving credit in SVN commit messages?
Date Tue, 21 Jan 2014 00:58:12 GMT
+1 to giving attribution at time of commit.

Cheers


On Mon, Jan 20, 2014 at 4:39 PM, Jesse Yates <jesse.k.yates@gmail.com>wrote:

> +1 To continue giving attribution (unless you wrote the code, in which
> case, whats the point, eh?)
>
> -------------------
> Jesse Yates
> @jesse_yates
> jyates.github.com
>
>
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <apurtell@apache.org>
> wrote:
>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> >
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> >
> > I've noticed that some committers are definitely not doing this.
> >
> > I think it is bad practice not to provide attribution to the contributor
> in
> > the commit message. When one is reviewing commit history, neither links
> to
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> tool
> > that does this of which I'm not aware (please let me know!).
> >
> > --
> > Best regards,
> >
> >    - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message