hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 谢良 <xieli...@xiaomi.com>
Subject 答复: test value used for HBase block size?
Date Thu, 12 Dec 2013 03:27:49 GMT
All the BucketCache, LruBlockCache and DoubleBlockache instances are
singleton(not per cf) in current codebase, and you mentioned block size could be set
per CF. so you should not expect to change the block size in those Cache ctor

发件人: Sergey Shelukhin [sergey@hortonworks.com]
发送时间: 2013年12月12日 3:22
收件人: dev@hbase.apache.org
主题: Re: test value used for HBase block size?

Ping? I'll file a JIRA

On Tue, Dec 10, 2013 at 3:59 PM, Sergey Shelukhin <sergey@hortonworks.com>wrote:

> I have a question...
> HStore ctor used by HRegion does: this.cacheConf = new CacheConfig(conf,
> family); which calls CacheConfig.instantiateBlockCache(conf) and creates
> BucketCache, LruBlockCache and DoubleBlockCache depending on config.
> However, BucketCache in ctor, as well as CacheConfig when creating others,
> uses StoreFile.DEFAULT_BLOCKSIZE_SMALL as block size (without getting from
> config or anything).
> DEFAULT_BLOCKSIZE_SMALL is described as:
> {code}
>   // Make default block size for StoreFiles 8k while testing.  TODO: FIX!
>   // Need to make it 8k for testing.
>   public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
> {code}
> Should it be 8k? Am I missing something? It's been like that forever (at
> least the constant, didn't check the usage).

NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
View raw message