hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Extensions for patches accepted by QA bot
Date Wed, 11 Dec 2013 21:02:05 GMT
I attached patch v2 to HBASE-10044 which would make QA bot accept the 3
extensions discussed here.

Sorry for the delay - was at a conference last week.


On Thu, Dec 5, 2013 at 9:10 AM, Nick Dimiduk <ndimiduk@gmail.com> wrote:

> Thanks Ted!
>
>
> On Thu, Dec 5, 2013 at 8:50 AM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > Alright.
> > Plan to stick with previous consensus of 3 file extensions.
> >
> > Cheers
> >
> >
> > On Wed, Dec 4, 2013 at 9:07 AM, Nick Dimiduk <ndimiduk@gmail.com> wrote:
> >
> > > I don't think that's a necessary filter; it'll still get
> false-positives
> > > like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> > > understanding in accepting and evaluating community contributions :)
> > > Running failing to apply a non-patch doesn't really hurt anything.
> > >
> > >
> > > On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yuzhihong@gmail.com> wrote:
> > >
> > > > Over in HBASE-10017, the following attachment triggered a QA warning:
> > > >
> > > >
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> > > >
> > > > Should the acceptance criteria include the notion that there should
> be
> > > JIRA
> > > > number in the filename ?
> > > >
> > > > Thanks
> > > >
> > > >
> > > > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <anoop.hbase@gmail.com>
> > > wrote:
> > > >
> > > > > +1 for .patch, .txt, .diff
> > > > >
> > > > > -Anoop-
> > > > >
> > > > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <ndimiduk@gmail.com>
> > > wrote:
> > > > >
> > > > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > > > >
> > > > > >
> > > > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yuzhihong@gmail.com>
> > wrote:
> > > > > >
> > > > > > > During review of
> > > > > > >   HBASE-10044 test-patch.sh should filter out documents
by
> known
> > > file
> > > > > > > extensions
> > > > > > > Jesse made the suggestion that QA bot only accepts files
with
> > > > > extensions
> > > > > > > .patch
> > > > > > > and .txt
> > > > > > >
> > > > > > > I want to get opinion from the community on this matter.
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message