hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Testing the fix for race condition between Compaction and StoreScanner.init
Date Mon, 02 Dec 2013 17:54:14 GMT
Is the proposed approach below acceptable ?

Cheers


On Wed, Nov 20, 2013 at 9:48 AM, Ted Yu <yuzhihong@gmail.com> wrote:

> As requested by Jonathan, I am posting the following approach for testing
> fix of HBASE-9949 :
>
>
> 1. Introduce config parameter for StoreScanner implementation which would
> be used by HStore for creating scanner
> 2. In TestStoreScanner, add StoreScanner implementation which extends
> StoreScanner and set the above config parameter to this class.
> 3. Register custom ChangedReadersObserver through the following API of
> HStore :
>
>   public void addChangedReaderObserver(ChangedReadersObserver o) {
>
> The BEFORE_SEEK hook would be activated before Store.getScanner() is
> called.
> The AFTER_SEEK hook can be activated at the end of ctor of StoreScanner
> wrapper created in #2
> The custom ChangedReadersObserver would activate the COMPACT_COMPLETE hook.
>
> Comments are welcome.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message